Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]Add scroll-to-top element #62

Closed
wants to merge 4 commits into from
Closed

[WIP]Add scroll-to-top element #62

wants to merge 4 commits into from

Conversation

Netacci
Copy link

@Netacci Netacci commented Oct 2, 2024 •
edited
Loading

Fixes

Description

This PR fixes the user accessibility issue of having to manually scroll back to the top on a long page.

Technical details

Added a new js file scroll.js that essentially hides or shows the scroll-to-top element when a user reaches 1000px height on the viewport.

Tests

  • Test by scrolling on this page.
  • Confirm you can't see the button till you scroll down a bit.
  • Confirm the button disappears when you are back at the top.
  • Confirm the button doesn't show on short pages

Screenshots

scroll-to-top

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@netlify Netlify
Copy link

netlify bot commented Oct 2, 2024 •
edited
Loading

✅ Deploy Preview for vocabulary-docs ready!

Name Link
🔨 Latest commit 9b7d3f6
🔍 Latest deploy log https://app.netlify.com/sites/vocabulary-docs/deploys/66fd21d89106750008222119
😎 Deploy Preview https://deploy-preview-62--vocabulary-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@possumbilities
Copy link
Contributor

Hi! Thank you for your contribution, please see the full details on the original Issue, especially:

Solutions here should explore non-js interventions. CSS pseudo elements using z-index stack positions and variable percentage based heights would offer a means to "reveal" the button after a degree of scrolling, and to visually hide the element on pages which do not reach a particular length.

Closing, due to use of Javascript here, outside scope of Issue direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Netacci Netacci

@possumbilities possumbilities

Labels
None yet
Projects
possumbilities
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Add a scroll-to-top element to UX for longer page contexts
2 participants
@Netacci @possumbilities