Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion added #104

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

SisiVero
Copy link
Contributor

@SisiVero SisiVero commented Oct 5, 2024

Fixes

Description

I created a new file for the faq making sure that the design system is followed.
I created a new .js file (accordion.js) where the functionality for the accordion is written.
I wrote a few css for the accodion layout in the style.css file (I will move this to vocabulary.css when this PR is being vetted).
I integrated accordion for nine faqs. This is because I want to confirm that the design system matches what the brand wants.
Attached are screenshots of the current main faq page without accordion, the accordion that I implemented displaying the open and close view.
I also ensured that links are added where they were with reference to the faq file in the faq repo as well as the live faq page.
I also added a cursor pointer to the questions and icons to let a user know that the question is clickable thereby improving UX.

Screenshots

Attched is a screengrab from the main faq page without accorddion:
faqWithoutAccordion

faq with accordion implmented(opened):
faqWithAccordion(Opened)

FAQ with Accordion implemented (closed):
faqWithAccordion(closed)

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow [best practices][best_practices].
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

@SisiVero SisiVero requested review from a team as code owners October 5, 2024 17:19
@SisiVero SisiVero requested review from TimidRobot, possumbilities and nimishbongale and removed request for a team October 5, 2024 17:19
Copy link

netlify bot commented Oct 5, 2024

Deploy Preview for vocabulary-docs failed.

Name Link
🔨 Latest commit 7dbfb87
🔍 Latest deploy log https://app.netlify.com/sites/vocabulary-docs/deploys/670e21dbb5687f0007d54a8d

@possumbilities
Copy link
Contributor

There's good work here, but for the time being see status of initial Issue.

After reviewing possible work directions here, it has become clear that more focused implementation specifications are needed for this to move stably forward. As such this Feature is now blocked by:

I'm leaving this PR open for now, and we'll revisit soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

[Feature] Add support for accordions
2 participants