-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accordion added #104
Open
SisiVero
wants to merge
8
commits into
creativecommons:main
Choose a base branch
from
SisiVero:main-faq-accordion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Accordion added #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SisiVero
requested review from
TimidRobot,
possumbilities and
nimishbongale
and removed request for
a team
October 5, 2024 17:19
❌ Deploy Preview for vocabulary-docs failed.
|
unwanted file deleted
Removed redundant code
There's good work here, but for the time being see status of initial Issue.
I'm leaving this PR open for now, and we'll revisit soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Description
I created a new file for the faq making sure that the design system is followed.
I created a new .js file (accordion.js) where the functionality for the accordion is written.
I wrote a few css for the accodion layout in the style.css file (I will move this to vocabulary.css when this PR is being vetted).
I integrated accordion for nine faqs. This is because I want to confirm that the design system matches what the brand wants.
Attached are screenshots of the current main faq page without accordion, the accordion that I implemented displaying the open and close view.
I also ensured that links are added where they were with reference to the faq file in the faq repo as well as the live faq page.
I also added a cursor pointer to the questions and icons to let a user know that the question is clickable thereby improving UX.
Screenshots
Attched is a screengrab from the main faq page without accorddion:
faq with accordion implmented(opened):
FAQ with Accordion implemented (closed):
Checklist
Update index.md
).main
ormaster
).visible errors.