Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Include Close Icon in the vocabulary design system #304

Closed
1 task done
egbadon-victor opened this issue Nov 5, 2024 · 0 comments · Fixed by #311
Closed
1 task done

[Feature] Include Close Icon in the vocabulary design system #304

egbadon-victor opened this issue Nov 5, 2024 · 0 comments · Fixed by #311
Assignees
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work

Comments

@egbadon-victor
Copy link
Contributor

Problem

Currently, any implementation that requires a close icon (say a modal for instance) can't be implemented based on the vocabulary design system standard because there is no close icon svg present.

Description

This feature solves this problem by implementing a close icon as an svg, following the same style used for icons like the cc-logo, or any of the social icons.

Alternatives

  • Do nothing. Let any close button implementations be done downstream.

Additional context

This issue is related to ;
The closing button for the "Confused need help " pop up pages is aligning with the cc logo #546
[Fix] icon overlay issue of the close button in modal #548

Implementation

  • I would be interested in implementing this feature.
@egbadon-victor egbadon-victor added ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🟩 priority: low Low priority and doesn't need to be rushed labels Nov 5, 2024
@cc-open-source-bot cc-open-source-bot moved this to Triage in WebDev Nov 5, 2024
@possumbilities possumbilities added 🏁 status: ready for work Ready for work and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Nov 7, 2024
@possumbilities possumbilities moved this from Triage to Backlog in WebDev Nov 7, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in WebDev Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants