[Bug] Button alignment hardcoded with pixel values

[Lakshay-Pruthi]

Description

The button alignment on the resource page is done using hardcode pixels which is not a good practice. Also it makes the responsiveness dependent on the dimension of buttons. Any changes made to button dimension will also require changes here. Example --> Missing repo button caused responsiveness issues.

Unnecessary code which can be deleted

Instead of this we can use flex properties in style.css

Reproduction

1. Go to resource page
2. See error.

Expectation

It should be properly aligned in the centre.

Resolution

• I would be interested in resolving this bug.

[Xaid-vfx]

Good catch. Apparently, the misalignment of download button is only in open data handbook resource and no other.
The misalignment is not due hard coded pixels because if it were it would have been same for all resources.

Thanks to your issue, I had to take a look at it. The reason behind this is a commit from @Keerthivardhan1 . Apparently, he was removed all repo links from resources that were not working. But due to this change in resource.html , the repo link of Open data handbook which was working fine is also compromised. So next to the download button there should be a repo button link, which is missing.

Here's the repo url that was compromised.

If this was intentional, then I would suggest to just remove the repourl from opendatahandbook.html and the issue would be resolved.

I request @possumbilities to take a look into this as the change is live already.

Raised an issue #144 regarding this. @Lakshay-Pruthi, you are welcome to take it up.

[Lakshay-Pruthi]

@Xaid-vfx Thanks for the details you provided. I completely agree the misalignment is due to missing repo button but ultimately this needs to be corrected as it is not a good practice and any changes made to dimensions of download or repo button will result into misalignment in future.

[Lakshay-Pruthi]

Updated issue title and description to address the main point.

[Keerthivardhan1]

@Lakshay-Pruthi
under the guidance of @possumbilities I had successfully resolved all the broken links this is one from them.
I think this issue is occurring with only --> open data hand book page.

Clicking on the button previously led to a website that is no longer available on the internet, namely lawrent.com.
we should not include the repository button again. For additional information, please refer to #11.

[Keerthivardhan1]

@Lakshay-Pruthi, you only need to organize the CSS styles, and your exploration in the website is really appreciative.

[Xaid-vfx]

Hey @Lakshay-Pruthi and @Keerthivardhan1,
We can carry this conversation to #144, as it addresses the issue accurately.

[abhishekshah5486]

Please assign this issue to me.
I have setup the project locally, would like to work upon this issue.

[Murdock9803]

@abhishekshah5486 The UI for the page has major improvements done, and the issue has become irrelevant since then.
We can close the issue as completed @possumbilities 🙌

[possumbilities]

@Murdock9803 Is there a specific PR that targets this best?

[Murdock9803]

@possumbilities The PR #304 targets the UI improvement for Resource Page. The button alignment and everything is taken care of there 🙌
refactored the html and css for resource page