Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Remove unnecessary spaces and format code #115

Closed
1 task done
Naman13Kumawat opened this issue Mar 25, 2023 · 4 comments
Closed
1 task done

[Feature] Remove unnecessary spaces and format code #115

Naman13Kumawat opened this issue Mar 25, 2023 · 4 comments
Assignees
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed ⛔️ status: discarded Will not be worked on

Comments

@Naman13Kumawat
Copy link

Problem

This is a follow up to the issue #101.

Description

All the html files under the "_site" folder have unnecessary spaces and requires formatting which will improve the readability of the code.
For instance, file present at "docs_site\all\index.html" have more than 2700 lines, but after removing spaces and with proper formatting it reduces to 675 lines of code.

-> index.html before formatting:
image

-> index.html after formatting:
image

Alternatives

To resolve this issue, we can use any HTML formatting extension. Here I've used Prettier.

Implementation

  • I would be interested in implementing this feature.
@Naman13Kumawat Naman13Kumawat added ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🟩 priority: low Low priority and doesn't need to be rushed labels Mar 25, 2023
@Naman13Kumawat Naman13Kumawat changed the title [Feature] <Remove unnecessary spaces and format code> [Feature] Remove unnecessary spaces and format code Mar 25, 2023
@arjunsaxena122
Copy link

can you assign this issue to me

@Naman13Kumawat
Copy link
Author

Naman13Kumawat commented Mar 25, 2023

@arjunsaxena122 Glad to hear that you want to contribute, but since the issue is still under status: awaiting triage, it can't be assigned. I am already interested in working on it as soon as it is open to work and also, it can only be assigned by a mentor.
For more information you can visit Contribution Guidelines

@possumbilities
Copy link
Contributor

@Naman13Kumawat I think it might be better to add this information to #101 so the work is happening on the same Issue since they're so related.

@possumbilities possumbilities added ⛔️ status: discarded Will not be worked on and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Mar 31, 2023
@Naman13Kumawat
Copy link
Author

@possumbilities Okay I'll add this information to #101 as a comment.

@TimidRobot TimidRobot self-assigned this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed ⛔️ status: discarded Will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants