Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade JavaScript code Using ES6 Concepts #167

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Upgrade JavaScript code Using ES6 Concepts #167

wants to merge 8 commits into from

Conversation

Keerthivardhan1
Copy link
Contributor

@Keerthivardhan1 Keerthivardhan1 commented Apr 3, 2023 •
edited by TimidRobot
Loading

Fixes

Fixes #110 by @keerthivardhan

Description

This PR Optimizes the JavaScript code using ES6 Concepts

Technical details

This code uses : -
Arrow Functions.
Template literals.
Destructuring.
const instead of let . . .
and required Documentation.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Keerthivardhan1 Keerthivardhan1 requested a review from a team as a code owner April 3, 2023 19:48
@Keerthivardhan1 Keerthivardhan1 requested review from annatuma and Shafiya-Heena and removed request for a team April 3, 2023 19:48
@Keerthivardhan1 Keerthivardhan1 mentioned this pull request Apr 3, 2023
Open
1 task
@Keerthivardhan1
Copy link
Contributor Author

Coming to Google Analytics, According to my understanding that part of code is already optimized. It just need to be documented. I did that. Thank you.

adidevs
adidevs suggested changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@adidevs adidevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Keerthivardhan1 ! These are good changes to the repository but as you might have noticed that the current state of your branch has merge conflicts with the base branch.

This is because your fork might not have been synced after the recent PRs that have been merged. Your code is missing those changes and thus the conflicts.

To solve this, kindly sync your fork of this repository and fetch - pull changes in your local dev environment, then modify the JS code appropriately. For starters, you can convert this to a draft PR so that the maintainers know that your are actively working on it.

@Keerthivardhan1 Keerthivardhan1 requested a review from adidevs April 4, 2023 17:07
@Keerthivardhan1
Copy link
Contributor Author

@adidevs, Now I think there is no merge conflicts. I resolved them. can you please review this PR.

adidevs
adidevs suggested changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@adidevs adidevs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great but requires a little more correction. Please make the necessary changes.

docs/_layouts/resource.html Outdated Show resolved Hide resolved
docs/_layouts/resource.html Outdated Show resolved Hide resolved
@Keerthivardhan1
resolved suggested changes in resources.html
17ada78
@Keerthivardhan1
Resolve Conversation of @digi-booster
ac924b1 
This commit changes UpdateQueryString() and RemoveQueryString() funcion to initial stage.
adidevs
adidevs suggested changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@adidevs adidevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Keerthivardhan1 , one minor change left.

docs/style.css Outdated Show resolved Hide resolved
@possumbilities possumbilities requested review from possumbilities and removed request for annatuma and Shafiya-Heena February 26, 2024 19:51
@TimidRobot TimidRobot changed the title Upgrade javascript code Using ES6 Concepts Upgrade JavaScript code Using ES6 Concepts Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digi-booster digi-booster digi-booster left review comments

@adidevs adidevs adidevs requested changes

@possumbilities possumbilities Awaiting requested review from possumbilities

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
possumbilities
Status: In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Upgrade project's JavaScript code with the power of ES6! for better performance.
3 participants
@Keerthivardhan1 @digi-booster @adidevs