diff --git a/crawlab/core/item.py b/crawlab/core/item.py index f452748..29fedb5 100644 --- a/crawlab/core/item.py +++ b/crawlab/core/item.py @@ -1,14 +1,9 @@ import sys -from typing import Iterable from crawlab.entity.ipc_message import IPCMessage def save_item(*items: dict): - return save_items(items) - - -def save_items(items: Iterable[dict]): msg = IPCMessage( type="data", payload=items, diff --git a/pyproject.toml b/pyproject.toml index 0b18d54..d975a01 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,6 +1,6 @@ [tool.poetry] name = "crawlab-sdk" -version = "0.7.0rc5" +version = "0.7.0rc6" description = "Python SDK for Crawlab" authors = ["Marvin Zhang <tikazyq@163.com>"] readme = "README.md" diff --git a/tests/core/test_item.py b/tests/core/test_item.py index 95cac77..be092f6 100644 --- a/tests/core/test_item.py +++ b/tests/core/test_item.py @@ -1,6 +1,6 @@ import json -from crawlab.core.item import save_item, save_items +from crawlab.core.item import save_item def test_save_item_single(capsys): @@ -33,53 +33,3 @@ def test_save_item_multiple(capsys): assert isinstance(message["payload"], list) assert len(message["payload"]) == 2 assert message["payload"] == list(test_items) - - -def test_save_items(capsys): - test_items = [ - {"name": "test1", "value": 123}, - {"name": "test2", "value": 456}, - {"name": "test3", "value": 789}, - ] - save_items(test_items) - - capsys_res = capsys.readouterr() - message = json.loads(capsys_res.out) - - assert message["type"] == "data" - assert message["ipc"] is True - assert isinstance(message["payload"], list) - assert len(message["payload"]) == 3 - assert message["payload"] == test_items - - -def test_save_items_empty(capsys): - save_items([]) - - capsys_res = capsys.readouterr() - message = json.loads(capsys_res.out) - - assert message["type"] == "data" - assert message["ipc"] is True - assert isinstance(message["payload"], list) - assert len(message["payload"]) == 0 - - -def test_save_items_generator(capsys): - def item_generator(): - yield {"name": "test1", "value": 123} - yield {"name": "test2", "value": 456} - - save_items(item_generator()) - - capsys_res = capsys.readouterr() - message = json.loads(capsys_res.out) - - assert message["type"] == "data" - assert message["ipc"] is True - assert isinstance(message["payload"], list) - assert len(message["payload"]) == 2 - assert message["payload"] == [ - {"name": "test1", "value": 123}, - {"name": "test2", "value": 456}, - ]