Skip to content

Commit e934279

Browse files
committed
feat(encoding)!: EncodeLabel does not consume LabelEncoder
see prometheus#135. this adjusts the parameter of `encode()` so that it only mutably borrows the encoder. Signed-off-by: katelyn martin <[email protected]>
1 parent 12923ca commit e934279

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/encoding.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ impl<'a> LabelSetEncoder<'a> {
240240
/// An encodable label.
241241
pub trait EncodeLabel {
242242
/// Encode oneself into the given encoder.
243-
fn encode(&self, encoder: LabelEncoder) -> Result<(), std::fmt::Error>;
243+
fn encode(&self, encoder: &mut LabelEncoder) -> Result<(), std::fmt::Error>;
244244
}
245245

246246
/// Encoder for a label.
@@ -343,7 +343,7 @@ impl<T: EncodeLabel> EncodeLabelSet for &[T] {
343343
}
344344

345345
for label in self.iter() {
346-
label.encode(encoder.encode_label())?
346+
label.encode(&mut encoder.encode_label())?
347347
}
348348

349349
Ok(())
@@ -363,7 +363,7 @@ impl EncodeLabelSet for NoLabelSet {
363363
}
364364

365365
impl<K: EncodeLabelKey, V: EncodeLabelValue> EncodeLabel for (K, V) {
366-
fn encode(&self, mut encoder: LabelEncoder) -> Result<(), std::fmt::Error> {
366+
fn encode(&self, encoder: &mut LabelEncoder) -> Result<(), std::fmt::Error> {
367367
let (key, value) = self;
368368

369369
let mut label_key_encoder = encoder.encode_label_key()?;

0 commit comments

Comments
 (0)