Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of dependency to cratedb-toolkit #25

Closed
amotl opened this issue Jun 5, 2024 · 2 comments
Closed

Get rid of dependency to cratedb-toolkit #25

amotl opened this issue Jun 5, 2024 · 2 comments

Comments

@amotl
Copy link

amotl commented Jun 5, 2024

Problem

CrateDB Toolkit includes a few SQLAlchemy patches reused by others. However, it must be removed as a dependency before upstreaming the adapter on behalf of GH-1, because it weighs in too heavy.

Solution

The incubating SQLAlchemy dialect for CrateDB will host the relevant SQLAlchemy patches and polyfills instead.

Action

There are already relevant patches at 80/20 status, which need to be completed, mostly by accompanying them with corresponding software tests and documentation sections.

The most prominent ones are likely those:

@amotl
Copy link
Author

amotl commented Oct 24, 2024

cratedb-toolkit is no longer a runtime dependency of the LangChain adapter. All relevant code has been refactored into sqlalchemy-cratedb.

@amotl amotl closed this as completed Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant