Skip to content

Commit 84e1679

Browse files
committed
Update reviewed points
* Use `Temp`, not `Temp2`. * Use `getTemp()`.
1 parent 26fe9bb commit 84e1679

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/ir_Daikin.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -225,12 +225,12 @@ bool IRDaikinESP::getPower(void) const {
225225
void IRDaikinESP::setTemp(const float temp) {
226226
float degrees = std::max(temp, static_cast<float>(kDaikinMinTemp));
227227
degrees = std::min(degrees, static_cast<float>(kDaikinMaxTemp));
228-
_.Temp2 = degrees * 2.0f;
228+
_.Temp = degrees * 2.0f;
229229
}
230230

231231
/// Get the current temperature setting.
232232
/// @return The current setting for temp. in degrees celsius.
233-
float IRDaikinESP::getTemp(void) const { return _.Temp2 / 2.0f; }
233+
float IRDaikinESP::getTemp(void) const { return _.Temp / 2.0f; }
234234

235235
/// Set the speed of the fan.
236236
/// @param[in] fan The desired setting.
@@ -537,7 +537,7 @@ stdAc::state_t IRDaikinESP::toCommon(void) const {
537537
result.power = _.Power;
538538
result.mode = toCommonMode(_.Mode);
539539
result.celsius = true;
540-
result.degrees = _.Temp2 / 2.0f;
540+
result.degrees = getTemp();
541541
result.fanspeed = toCommonFanSpeed(getFan());
542542
result.swingv = _.SwingV ? stdAc::swingv_t::kAuto :
543543
stdAc::swingv_t::kOff;
@@ -564,7 +564,7 @@ String IRDaikinESP::toString(void) const {
564564
result += addBoolToString(_.Power, kPowerStr, false);
565565
result += addModeToString(_.Mode, kDaikinAuto, kDaikinCool, kDaikinHeat,
566566
kDaikinDry, kDaikinFan);
567-
result += addTempFloatToString(_.Temp2 / 2.0f);
567+
result += addTempFloatToString(getTemp());
568568
result += addFanToString(getFan(), kDaikinFanMax, kDaikinFanMin,
569569
kDaikinFanAuto, kDaikinFanQuiet, kDaikinFanMed);
570570
result += addBoolToString(_.Powerful, kPowerfulStr);

src/ir_Daikin.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ union DaikinESPProtocol{
9999
uint64_t Mode :3;
100100
uint64_t :1;
101101
// Byte 22
102-
uint64_t Temp2 :8; // Temp2 should be between 20 - 64 (10 C - 32 C)
102+
uint64_t Temp :8; // Temp should be between 20 - 64 (10 C - 32 C)
103103
// Byte 23
104104
uint64_t :8;
105105

0 commit comments

Comments
 (0)