Skip to content

Commit 19bf1f8

Browse files
authored
Feature/fix pdf output path (#128)
* Fix from rawlog * Fixed pdf output path * Replaced old Resume * Renamed Download CV Button to Download Resume
1 parent 07d9ba7 commit 19bf1f8

File tree

6 files changed

+12
-12
lines changed

6 files changed

+12
-12
lines changed

cypress/e2e/base-checks.cy.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ describe('Base Checks', () => {
3737

3838
cy.get('nav a[download]')
3939
.should('be.visible')
40-
.should('contain.text', 'Download CV')
41-
.should('have.attr', 'download', 'CV-CraigWayne.pdf');
40+
.should('contain.text', 'Download Resume')
41+
.should('have.attr', 'download', 'Resume-CraigWayneGovender.pdf');
4242

4343
})
4444

@@ -106,4 +106,4 @@ describe('Base Checks', () => {
106106

107107
cy.window().its('scrollY').should('eq', 0);
108108
})
109-
})
109+
})

resume-generator/create_pdf_from_html.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,6 @@ const __filename = fileURLToPath(import.meta.url);
6060
const __dirname = path.dirname(__filename);
6161

6262
const input_html_file = path.resolve(__dirname, '..', 'build/resume', 'index.html');
63-
const output_pdf_file = path.resolve(__dirname, '..', 'build', 'resume.pdf');
63+
const output_pdf_file = path.resolve(__dirname, '..', 'build', 'Resume-CraigWayneGovender.pdf');
6464

6565
create_pdf_from_html(input_html_file, output_pdf_file);

src/App.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ function AppContent() {
2727
if (window["gtag"] !== undefined) {
2828
window["gtag"]("event", "button_click", {
2929
event_category: "Engagement",
30-
event_label: "Download CV",
30+
event_label: "Download Resume",
3131
value: 1,
3232
});
3333
}
@@ -162,7 +162,7 @@ function AppContent() {
162162
onClick={() => trackDownloadCV()}
163163
>
164164
<Download className="w-3 h-3" />
165-
Download CV
165+
Download Resume
166166
</a>
167167
</Button>
168168
</div>
@@ -226,7 +226,7 @@ function AppContent() {
226226
onClick={() => trackDownloadCV()}
227227
>
228228
<Download className="w-3 h-3" />
229-
Download CV
229+
Download Resume
230230
</a>
231231
</Button>
232232
</motion.div>

src/components/Contact.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ export function Contact({data, socialLinks, cvData}: ContactProps) {
146146

147147
<div className="text-center space-y-8">
148148
<motion.div
149-
className="flex justify-center gap-6"
149+
className="flex flex-wrap justify-center gap-6"
150150
variants={socialContainerVariants}
151151
initial="hidden"
152152
whileInView="visible"
@@ -172,7 +172,7 @@ export function Contact({data, socialLinks, cvData}: ContactProps) {
172172
<Button variant="outline" size="lg" className="gap-2" asChild>
173173
<a href={cvData.path} download={cvData.fileName}>
174174
<Download className="w-5 h-5"/>
175-
Download CV
175+
Download Resume
176176
</a>
177177
</Button>
178178
</motion.div>
@@ -215,4 +215,4 @@ export function Contact({data, socialLinks, cvData}: ContactProps) {
215215
</div>
216216
</section>
217217
);
218-
}
218+
}

src/data/portfolio.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ export const portfolioData = {
1313
"Crafting exceptional digital experiences with modern web technologies. Specializing in TypeScript stacks, and creating scalable architectures that drive business growth.",
1414
yearsOfExperience: 8,
1515
email: abstracted_data.email,
16-
cvPath: "/CV-CraigWayne.pdf",
17-
cvFileName: "CV-CraigWayne.pdf",
16+
cvPath: "/Resume-CraigWayneGovender.pdf",
17+
cvFileName: "Resume-CraigWayneGovender.pdf",
1818
profileImage: "/profile.png",
1919
socialLinks: {
2020
github: "https://github.com/craigiswayne",

src/public/CV-CraigWayne.pdf

-96.1 KB
Binary file not shown.

0 commit comments

Comments
 (0)