Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows terminal support #16

Open
craigfe opened this issue Jun 29, 2021 · 1 comment
Open

Windows terminal support #16

craigfe opened this issue Jun 29, 2021 · 1 comment

Comments

@craigfe
Copy link
Owner

craigfe commented Jun 29, 2021

The test suite currently passes on Windows (thanks to #15), but the terminal handling doesn't behave correctly on Windows terminal & Cygwin terminal:

_src_progress.2021-06-29.10-08-43.mp4

Originally posted by @emillon in #15 (comment)

Details about terminal control sequences on Windows can be found here. The fix will probably involve touching Terminal.Ansi, and perhaps also renderer.ml in the Progress library.
craigfe added a commit to craigfe/opam-repository that referenced this issue Jun 29, 2021
@craigfe
[new release] terminal and progress (0.2.1)
3faba93 
CHANGES:

- Fix the count segment of `Progress.counter` (when `pp` is passed) to show the
  running total rather than the latest reported value. (craigfe/progress#19; @craigfe, report
  by @Ngoguey42)
- Fix `Terminal` stubs on MacOS. (craigfe/progress#13; @craigfe, report by @Ngoguey42)
- Fix package tests on Windows. `Progress` does not yet support the Windows and
  Cygwin terminals; this is tracked by craigfe/progress#16. (craigfe/progress#15; @emillon)
@craigfe craigfe mentioned this issue Jun 29, 2021
Merged
craigfe added a commit to craigfe/opam-repository that referenced this issue Jun 29, 2021
@craigfe
[new release] terminal and progress (0.2.1)
25a3941 
CHANGES:

- Fix the count segment of `Progress.counter` (when `pp` is passed) to show the
  running total rather than the latest reported value. (craigfe/progress#19; @craigfe, report
  by @Ngoguey42)
- Fix `Terminal` stubs on MacOS. (craigfe/progress#13; @craigfe, report by @Ngoguey42)
- Fix package tests on Windows. `Progress` does not yet support the Windows and
  Cygwin terminals; this is tracked by craigfe/progress#16. (craigfe/progress#15; @emillon)
craigfe added a commit to craigfe/opam-repository that referenced this issue Jun 29, 2021
@craigfe
[new release] terminal and progress (0.2.1)
ab4d781 
CHANGES:

- Fix the count segment of `Progress.counter` (when `pp` is passed) to show the
  running total rather than the latest reported value. (craigfe/progress#19; @craigfe, report
  by @Ngoguey42)
- Fix `Terminal` stubs on MacOS. (craigfe/progress#13; @craigfe, report by @Ngoguey42)
- Fix package tests on Windows. `Progress` does not yet support the Windows and
  Cygwin terminals; this is tracked by craigfe/progress#16. (craigfe/progress#15; @emillon)
@emillon
Copy link
Contributor

emillon commented Jul 7, 2021

to be honest, even opam is a bit broken in windows terminal:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emillon @craigfe