diff --git a/ui/src/Dashboard/TestRunDuration.tsx b/ui/src/Dashboard/TestRunDuration.tsx index 8bb9bcb61..94893d2a1 100644 --- a/ui/src/Dashboard/TestRunDuration.tsx +++ b/ui/src/Dashboard/TestRunDuration.tsx @@ -1,6 +1,7 @@ import * as React from "react"; import { List, ListItem, ListItemText, makeStyles } from "@material-ui/core"; import { Link } from "@reach/router"; +import CleanLink from "../Link/CleanLink"; interface TestRunDurationProps { publicId: string; @@ -53,13 +54,13 @@ const TestRunDuration = ({ - Slowest test case - + {slowestTestCaseDuration}s diff --git a/ui/src/Link/CleanLink.tsx b/ui/src/Link/CleanLink.tsx new file mode 100644 index 000000000..980d9e74c --- /dev/null +++ b/ui/src/Link/CleanLink.tsx @@ -0,0 +1,16 @@ +import * as React from "react"; +import { Link } from "@reach/router"; +import { styled } from "@material-ui/core/styles"; + +const CleanLink = styled(Link)({ + textDecoration: "none", + color: "blue", + "&:hover": { + textDecoration: "underline" + }, + "&:visited": { + color: "blue" + } +}); + +export default CleanLink; diff --git a/ui/src/TestCase/TestCaseDetails.tsx b/ui/src/TestCase/TestCaseDetails.tsx index cb792c9cc..c280957ff 100644 --- a/ui/src/TestCase/TestCaseDetails.tsx +++ b/ui/src/TestCase/TestCaseDetails.tsx @@ -16,6 +16,7 @@ import TestSuiteSystemOut from "../TestOutput/TestSuiteSystemOut"; import TestSuiteSystemErr from "../TestOutput/TestSuiteSystemErr"; import { getTabCurrentValue } from "../Tabs/TabValue"; import TestCaseSummary from "./TestCaseSummary"; +import CleanLink from "../Link/CleanLink"; const useStyles = makeStyles(theme => ({ paper: { @@ -39,25 +40,25 @@ const buildHeaderIntermediateLinks = ( if (testCase.packageName != null && testCase.packageName !== "") { headerIntermediateLinks.push( - {testCase.packageName} - + ); } if (testCase.className != null && testCase.className !== "") { headerIntermediateLinks.push( - {testCase.className} - + ); } return headerIntermediateLinks; diff --git a/ui/src/TestCase/TestCaseFailurePanel.tsx b/ui/src/TestCase/TestCaseFailurePanel.tsx index 1fcb29522..f81dc736f 100644 --- a/ui/src/TestCase/TestCaseFailurePanel.tsx +++ b/ui/src/TestCase/TestCaseFailurePanel.tsx @@ -10,6 +10,7 @@ import { makeStyles } from "@material-ui/core/styles"; import { TestCase } from "../model/TestRunModel"; import { Link } from "@reach/router"; import { Typography } from "@material-ui/core"; +import CleanLink from "../Link/CleanLink"; const useStyles = makeStyles(() => ({ panelActions: { @@ -50,32 +51,32 @@ const TestCaseFailurePanel = ({ {!testCase.passed && ( )} {testCase.hasSystemOut && ( )} {testCase.hasSystemErr && ( )} diff --git a/ui/src/TestCase/list/TestCaseListRow.tsx b/ui/src/TestCase/list/TestCaseListRow.tsx index 7e6dc07be..3fb6041f6 100644 --- a/ui/src/TestCase/list/TestCaseListRow.tsx +++ b/ui/src/TestCase/list/TestCaseListRow.tsx @@ -2,8 +2,8 @@ import * as React from "react"; import { TableCell, TableRow } from "@material-ui/core"; import { TestCase } from "../../model/TestRunModel"; import TestCaseResultIcon from "../TestCaseResultIcon"; -import { Link } from "@reach/router"; import { fullTestCaseName } from "../../model/TestCaseHelpers"; +import CleanLink from "../../Link/CleanLink"; interface TestCaseListRowProps { publicId: string; @@ -36,12 +36,12 @@ const TestCaseListRow = ({ role="rowcell" size="small" > - {showFullTestCaseName ? fullTestCaseName(testCase) : testCase.name} - + ); const durationRowCell = ( diff --git a/ui/src/TestSuite/TestSuiteDetails.tsx b/ui/src/TestSuite/TestSuiteDetails.tsx index e16ca3525..b2c49af6b 100644 --- a/ui/src/TestSuite/TestSuiteDetails.tsx +++ b/ui/src/TestSuite/TestSuiteDetails.tsx @@ -14,6 +14,7 @@ import TestSuiteSystemOut from "../TestOutput/TestSuiteSystemOut"; import TestSuiteSystemErr from "../TestOutput/TestSuiteSystemErr"; import { getTabCurrentValue } from "../Tabs/TabValue"; import BreadcrumbPageHeader from "../BreadcrumbPageHeader"; +import CleanLink from "../Link/CleanLink"; interface TestSuiteDetailsProps { publicId: string; @@ -34,13 +35,13 @@ const buildHeaderIntermediateLinks = (publicId, testSuite) => { if (testSuite.packageName != null && testSuite.packageName !== "") { headerIntermediateLinks.push( - {testSuite.packageName} - + ); } diff --git a/ui/src/TestSuite/TestSuiteList.tsx b/ui/src/TestSuite/TestSuiteList.tsx index 0fbf87080..754bca769 100644 --- a/ui/src/TestSuite/TestSuiteList.tsx +++ b/ui/src/TestSuite/TestSuiteList.tsx @@ -5,7 +5,7 @@ import TableCell from "@material-ui/core/TableCell"; import TableHead from "@material-ui/core/TableHead"; import TableRow from "@material-ui/core/TableRow"; import { TestSuite } from "../model/TestRunModel"; -import { Link } from "@reach/router"; +import CleanLink from "../Link/CleanLink"; interface TestSuiteListProps { publicId: String; @@ -32,12 +32,12 @@ const TestSuiteList = ({ publicId, testSuites }: TestSuiteListProps) => { data-testid={`test-suite-class-name-${testSuite.idx}`} size="small" > - + {testSuite.packageName != null ? `${testSuite.packageName}.` : null} {testSuite.className} - + {testSuite.testCount} {testSuite.passingCount}