From f70d5910cd39aa6b09b632663e3457ff7f1a20a7 Mon Sep 17 00:00:00 2001 From: Oli Date: Tue, 21 May 2024 14:01:08 +0200 Subject: [PATCH 1/2] Fix #87 - Correct return type Correct return type to match `asModelFailure()` --- src/controllers/SaveController.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/controllers/SaveController.php b/src/controllers/SaveController.php index 50b4a77..d5cad12 100644 --- a/src/controllers/SaveController.php +++ b/src/controllers/SaveController.php @@ -176,9 +176,9 @@ private function _returnSuccess(Entry $entry, $isSpam = false): Response * * @param Settings $settings * @param Entry $entry - * @return Response + * @return Response|null */ - private function _returnError(Settings $settings, Entry $entry): Response + private function _returnError(Settings $settings, Entry $entry): ?Response { if ($this->hasEventHandlers(self::EVENT_AFTER_ERROR)) { $this->trigger(self::EVENT_AFTER_ERROR, new SaveEvent([ From f9c3ba865e1d49288ac83c1845c6a0991793ff23 Mon Sep 17 00:00:00 2001 From: Oli Date: Tue, 21 May 2024 14:06:12 +0200 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1b1f54f..effc963 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,10 @@ # Release Notes for Guest Entries +## Unreleased + +### Fixed +- Fixed a PHP error that could occur on validation failure. ([#87](https://github.com/craftcms/guest-entries/issues/87)) + ## 4.0.0 - 2024-03-19 - Added Craft 5 compatibility.