Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x]: store location edit button does not open slideout by default #3536

Closed
piotrpog opened this issue Jun 9, 2024 · 7 comments
Closed

Comments

@piotrpog
Copy link

piotrpog commented Jun 9, 2024

What happened?

Description

In store management/general we have list of locations. After clicking three dots next to the location and selecting "edit" i expected slideout to open. But instead i was moved to separate page.

Craft CMS version

5.1.1.0

Craft Commerce version

5.0.9

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

Copy link

linear bot commented Jun 9, 2024

@nfourtythree
Copy link
Contributor

Hi @piotrpog

Thank you for your message.

Is this for editing the store location or the inventory locations associated to the store?

Thanks.

@piotrpog
Copy link
Author

This would be store locations - store managment/general, clicking three dots and selecting "edit". I expected this should trigger slideout.

image

@nfourtythree
Copy link
Contributor

Hi @piotrpog

Clicking edit next to Store Location (as you said in your message) seems to work as expected for me.

qiLysyiGpfMAyZeuLj81rL4c2jtcX3QflBnYrbPu.mp4

Thanks

@piotrpog
Copy link
Author

@nfourtythree
How about on the bottom of this page, under "inventory locations" header, in "default" tile?

@nfourtythree
Copy link
Contributor

HI @piotrpog

Ah so you are looking at the inventory locations.

These are specifically designed to not open in a slide out. This is the same reason why they have their own side bar navigation item.

Inventory locations are not owned by any one particular store but rather just associated with which ever stores used them. For this reason we opted not to have a slide out to avoid any confusion to when editing this data, by taking the user to the specific edit page this is to show that the changes you are making are not for one specific store but global across the system.

Hope this helps, thanks!

@piotrpog
Copy link
Author

@nfourtythree
Thank you for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants