Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x]: edit actions available for order when Edit Orders permission not enabled #3534

Closed
jmauzyk opened this issue Jun 6, 2024 · 2 comments
Assignees
Labels
bug commerce4 Issues related to Commerce v4 Craft Commerce

Comments

@jmauzyk
Copy link

jmauzyk commented Jun 6, 2024

What happened?

Description

When a user has the "Manage orders" permission enabled, but not the "Edit orders" permission, a number of actions to edit and remove remain visible. It's possible to click these actions and make changes to the order and line items, although it's not possible to save.

Steps to reproduce

  1. Enable the "Manage orders" permission for a user without enabling the sub-permission "Edit orders".
  2. With this user account logged in, view a CP order edit page.

Expected behavior

Expected edit and remove action buttons to be hidden since "Edit orders" is not enabled.

Actual behavior

An "Edit" and "Edit adjustments" button remain visible on the order, as well as "Edit" and "Remove" buttons for the line items.

Craft CMS version

Pro 4.9.7

Craft Commerce version

4.6.2

PHP version

8.2.19

Operating system and version

Linux 6.6.26-linuxkit

Database type and version

PostgreSQL 14.9

Image driver and version

Imagick 3.7.0 (ImageMagick 6.9.11-60)

Installed plugins and versions

No response

@jmauzyk jmauzyk added bug commerce4 Issues related to Commerce v4 Craft Commerce labels Jun 6, 2024
Copy link

linear bot commented Jun 6, 2024

@nfourtythree nfourtythree self-assigned this Jun 14, 2024
@nfourtythree
Copy link
Contributor

Hi @jmauzyk

Thank you for raising this issue, we have pushed a fix for this which will be included in the next release of Commerce.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug commerce4 Issues related to Commerce v4 Craft Commerce
Projects
None yet
Development

No branches or pull requests

2 participants