[3.x/4.x]: 'Qty must be no less than 1.' reported twice for low quantity

[msbit]

What happened?

Description

Due to the rule being applied in two places:

LineItem::defineRules
https://github.com/craftcms/commerce/blob/3.4.23/src/models/LineItem.php#L465
https://github.com/craftcms/commerce/blob/4.3.2/src/models/LineItem.php#L420

Variant::getLineItemRules()
https://github.com/craftcms/commerce/blob/3.4.23/src/elements/Variant.php#L820
https://github.com/craftcms/commerce/blob/4.3.2/src/elements/Variant.php#L826

at validation time, the error is added twice.

I haven't tested the 4.x branch, but the code appears to be the same.

Steps to reproduce

$lineItem = new \craft\commerce\models\LineItem([
    'purchasableId' => Craft::$app->getElements()->createElementQuery(\craft\commerce\elements\Variant::class)->scalar(),
    'qty' => 0,
]);
$lineItem->validate();
var_dump($lineItem->getErrors('qty'));

Expected behavior

array(1) {
  [0] =>
  string(27) "Qty must be no less than 1."
}

Actual behavior

array(2) {
  [0] =>
  string(27) "Qty must be no less than 1."
  [1] =>
  string(27) "Qty must be no less than 1."
}

Craft CMS version

"craftcms/cms": "3.9.5"

Craft Commerce version

"craftcms/commerce": "3.4.23"

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

[lukeholder]

Thanks for reporting that! I’ve just fixed it for the next release.

To get the fix early, change your craftcms/commerce requirement in composer.json to:

"require": {
  "craftcms/commerce": "dev-develop#ad6803123e4dbe5127fb7780a9ed650dda27ac29",
  "...": "..."
}

Then run composer update.

We will update you here once the release is out. Thanks.