Skip to content

Commit 1a43a2e

Browse files
ctzcpu
authored andcommitted
Add comment indicating source of signature budget
1 parent 85ada2a commit 1a43a2e

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

src/verify_cert.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,13 @@ impl Budget {
242242

243243
impl Default for Budget {
244244
fn default() -> Self {
245-
Self { signatures: 100 }
245+
Self {
246+
// This limit is taken from the remediation for golang CVE-2018-16875. However,
247+
// note that golang subsequently implemented AKID matching due to this limit
248+
// being hit in real applications (see <https://github.com/spiffe/spire/issues/1004>).
249+
// So this may actually be too aggressive.
250+
signatures: 100,
251+
}
246252
}
247253
}
248254

0 commit comments

Comments
 (0)