Skip to content

Commit 87bac81

Browse files
committed
TestAstUtils: changed a few isSameExpressionTest() asserts to TODO / added some TODOs about missing test coverage [skip ci]
1 parent 30e8814 commit 87bac81

1 file changed

Lines changed: 8 additions & 6 deletions

File tree

test/testastutils.cpp

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ class TestAstUtils : public TestFixture {
3535

3636
private:
3737

38+
// TODO: test C code
39+
3840
void run() override {
3941
TEST_CASE(findLambdaEndTokenTest);
4042
TEST_CASE(findLambdaStartTokenTest);
@@ -182,7 +184,7 @@ class TestAstUtils : public TestFixture {
182184
ASSERT_LOC(tokenizer.tokenize(istr, "test.cpp"), file, line);
183185
const Token * const tok1 = Token::findsimplematch(tokenizer.tokens(), tokStr1, strlen(tokStr1));
184186
const Token * const tok2 = Token::findsimplematch(tok1->next(), tokStr2, strlen(tokStr2));
185-
return (isSameExpression)(false, false, tok1, tok2, library, false, true, nullptr);
187+
return (isSameExpression)(/*cpp*/ true, false, tok1, tok2, library, false, true, nullptr);
186188
}
187189

188190
void isSameExpressionTest() {
@@ -196,11 +198,11 @@ class TestAstUtils : public TestFixture {
196198
ASSERT_EQUALS(false, isSameExpression("x < y;", "x", "y"));
197199
ASSERT_EQUALS(true, isSameExpression("(x + 1) < (x + 1);", "+", "+"));
198200
ASSERT_EQUALS(false, isSameExpression("(x + 1) < (x + 1L);", "+", "+"));
199-
ASSERT_EQUALS(true, isSameExpression("(1 + x) < (x + 1);", "+", "+"));
201+
TODO_ASSERT_EQUALS(true, false, isSameExpression("(1 + x) < (x + 1);", "+", "+"));
200202
ASSERT_EQUALS(false, isSameExpression("(1.0l + x) < (1.0 + x);", "+", "+"));
201-
ASSERT_EQUALS(true, isSameExpression("(0.0 + x) < (x + 0x0p+0);", "+", "+"));
203+
TODO_ASSERT_EQUALS(true, false, isSameExpression("(0.0 + x) < (x + 0x0p+0);", "+", "+"));
202204
ASSERT_EQUALS(true, isSameExpression("void f() {double y = 1e1; (x + y) < (x + 10.0); } ", "+", "+"));
203-
ASSERT_EQUALS(true, isSameExpression("void f() {double y = 1e1; (x + 10.0) < (y + x); } ", "+", "+"));
205+
TODO_ASSERT_EQUALS(true, false, isSameExpression("void f() {double y = 1e1; (x + 10.0) < (y + x); } ", "+", "+"));
204206
ASSERT_EQUALS(true, isSameExpression("void f() {double y = 1e1; double z = 10.0; (x + y) < (x + z); } ", "+", "+"));
205207
ASSERT_EQUALS(true, isSameExpression("A + A", "A", "A"));
206208

@@ -220,7 +222,7 @@ class TestAstUtils : public TestFixture {
220222
ASSERT_LOC(tokenizer.tokenize(istr, "test.cpp"), file, line);
221223
const Token * const tok1 = Token::findsimplematch(tokenizer.tokens(), startPattern, strlen(startPattern));
222224
const Token * const tok2 = Token::findsimplematch(tokenizer.tokens(), endPattern, strlen(endPattern));
223-
return (isVariableChanged)(tok1, tok2, 1, false, &settings, true);
225+
return (isVariableChanged)(tok1, tok2, 1, false, &settings, /*cpp*/ true);
224226
}
225227

226228
void isVariableChangedTest() {
@@ -397,7 +399,7 @@ class TestAstUtils : public TestFixture {
397399
const Token* const start = Token::findsimplematch(tokenizer.tokens(), startPattern, strlen(startPattern));
398400
const Token* const end = Token::findsimplematch(start, endPattern, strlen(endPattern));
399401
const Token* const expr = Token::findsimplematch(tokenizer.tokens(), var, strlen(var));
400-
return (findExpressionChanged)(expr, start, end, &settings, true);
402+
return (findExpressionChanged)(expr, start, end, &settings, /*cpp*/ true);
401403
}
402404

403405
void isExpressionChangedTest()

0 commit comments

Comments
 (0)