Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs only changes PRs can't be merged because of set_status job requirement #571

Open
NeroBurner opened this issue May 30, 2022 · 1 comment · May be fixed by #613
Open

docs only changes PRs can't be merged because of set_status job requirement #571

NeroBurner opened this issue May 30, 2022 · 1 comment · May be fixed by #613
Labels
infrastructure Problems with the CI infrastructure or CI jobs

Comments

@NeroBurner
Copy link

When a PR touches only the docs folder the resulting PRs can't get a green status. The set_status job is required, but will never be run

The status for maintainer will look like this, never enabling the merge button

Screenshot_20220530_150502
@NeroBurner
Copy link
Author

found the following explanation https://stackoverflow.com/questions/52200096/github-pull-request-waiting-for-status-to-be-reported

It doesn't perfectly fit our case (the issue is about sometimes hanging PRs), but maybe it is useful information on our path to find a fix

@NeroBurner NeroBurner mentioned this issue Jun 20, 2022
Merged
@NeroBurner NeroBurner added the infrastructure Problems with the CI infrastructure or CI jobs label Sep 9, 2022
@NeroBurner NeroBurner linked a pull request Sep 9, 2022 that will close this issue
Open
NeroBurner added a commit that referenced this issue Sep 9, 2022
@NeroBurner
CI: always run set-matrix to prevent locked up PRs on docs
3d256e2 
Letting `set_matrix` job run always, because it is required to report its
status for an approved PR to be merged.

Fixes: #571
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infrastructure Problems with the CI infrastructure or CI jobs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI: always run set-matrix to prevent locked up PRs on docs cpp-pm/hunter
1 participant
@NeroBurner