use clang-cl for Windows (instead of clang)

Author: TymianekPL

.github/workflows/cmake.yml

@@ -22,14 +22,7 @@ jobs:
       - name: Check formatting
         run: |
           git fetch --depth=1 origin master
-          FILES=$(git ls-files '*.cpp' '*.hpp' '*.h' '*.ixx')
-          if [ -n "$FILES" ]; then
-            clang-format -style=file -output-replacements-xml $FILES | grep "<replacement " >/dev/null \
-              && { echo "Code is not properly formatted"; exit 1; } \
-              || echo "All good"
-          else
-            echo "No files to format"
-          fi
+          clang-format -style=file -output-replacements-xml $(git ls-files '*.cpp' '*.h' '*.ixx' '*.hpp') | grep "<replacement " && echo "Code is not properly formatted" && exit 1 || echo "All good"
 
   build:
     name: Build project
@@ -62,30 +55,30 @@ jobs:
           fi
         shell: bash
 
-      - name: Configure (Ubuntu + clang)
-        if: matrix.os == 'ubuntu-latest' && matrix.compiler == 'clang'
+      - name: Configure CMake
         run: |
           mkdir build
           cd build
-          cmake -G Ninja -DCMAKE_CXX_COMPILER=clang++ ..
+          if [ "${{ matrix.os }}" == "ubuntu-latest" ]; then
+            if [ "${{ matrix.compiler }}" == "clang" ]; then
+              cmake -G Ninja -DCMAKE_CXX_COMPILER=clang++ ..
+            fi
+          elif [ "${{ matrix.os }}" == "windows-latest" ]; then
+            if [ "${{ matrix.compiler }}" == "msvc" ]; then
+              # Force the real MSVC toolset (cl.exe)
+              cmake -G "Visual Studio 17 2022" -A x64 ..
+            elif [ "${{ matrix.compiler }}" == "clang" ]; then
+              # Explicit clang-cl on Windows
+              cmake -G Ninja -DCMAKE_CXX_COMPILER=clang-cl ..
+            fi
+          fi
         shell: bash
 
-      - name: Configure (Windows + msvc)
-        if: matrix.os == 'windows-latest' && matrix.compiler == 'msvc'
-        run: |
-          mkdir build
-          cd build
-          cmake -G "Visual Studio 17 2022" -A x64 ..
-        shell: pwsh
-
-      - name: Configure (Windows + clang)
-        if: matrix.os == 'windows-latest' && matrix.compiler == 'clang'
-        run: |
-          mkdir build
-          cd build
-          cmake -G Ninja -DCMAKE_CXX_COMPILER=clang++ ..
-        shell: pwsh
-
       - name: Build
-        run: cmake --build build --config Release
+        run: |
+          if [ "${{ matrix.os }}" == "windows-latest" ] && [ "${{ matrix.compiler }}" == "msvc" ]; then
+            cmake --build build --config Release
+          else
+            cmake --build build --config Release
+          fi
         shell: bash