Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MonacoEditor.tsx #96

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

vedant-z
Copy link

Fixes #91

@vercel
Copy link

vercel bot commented Mar 10, 2023

@vedant-z is attempting to deploy a commit to the CP Initiative Team on Vercel.

A member of the Team first needs to authorize it.

@vedant-z
Copy link
Author

@thecodingwizard Please review this.

@thecodingwizard
Copy link
Member

This looks good, thanks for implementing this! Can you add a comment somewhere explaining what this code does / why it's needed? (maybe also link to the Github issue). That way future developers know why this code was included

@vedant-z
Copy link
Author

@thecodingwizard Done

@thecodingwizard
Copy link
Member

Thanks! Looks like typescript tests are failing; can you take a look? https://github.com/cpinitiative/ide/actions/runs/4390557348/jobs/7692803760

(you can debug locally by running next build)

@thecodingwizard
Copy link
Member

bump @vedant-z . take your time if you're busy; I just wanted to make sure you saw my response :)

@vercel
Copy link

vercel bot commented Mar 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ide ❌ Failed (Inspect) Mar 14, 2023 at 11:49PM (UTC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some reserved words not highlighting java
2 participants