Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests should ignore files listed in MANIFEST.SKIP #31

Open
charsbar opened this issue Sep 18, 2017 · 1 comment
Open

Some tests should ignore files listed in MANIFEST.SKIP #31

charsbar opened this issue Sep 18, 2017 · 1 comment

Comments

@charsbar
Copy link

Tux pointed out that no_symlinks should exclude files listed in MANIFEST.SKIP even when we are under developing environment (i.e. Test::Kwalitee), because they don't go into a distribution. There should be more tests that should respect MANIFEST.SKIP, or, maybe everything listed in MANIFEST.SKIP should be excluded before actual file testing.

When we implement this, it would also be better to have another test that looks at MANIFEST.SKIP to see if important files are not listed, so that Test::Kwalitee users don't get upset when they are told something is missing when they see it in the repository.

This needs to change the order of testing.

@dolmen
Copy link
Member

dolmen commented Sep 20, 2017

For implementer: code for handling MANIFEST.SKIP is available in ExtUtils::Manifest::maniskip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants