Disable ANALYZE on read-only replica

Author: jmg-duarte

crates/autopilot/src/database/mod.rs

@@ -161,11 +161,12 @@ impl Metrics {
     }
 }
 
-pub fn run_database_metrics_work(db: Postgres) {
+pub fn run_database_metrics_work(db: Postgres, run_analyze: bool) {
     let span = tracing::info_span!("database_metrics");
-    // Spawn the task for updating large table statistics
-    tokio::spawn(update_large_tables_stats(db.clone()).instrument(span.clone()));
-
+    if run_analyze {
+        // Spawn the task for updating large table statistics
+        tokio::spawn(update_large_tables_stats(db.clone()).instrument(span.clone()));
+    }
     // Spawn the task for database metrics
     tokio::task::spawn(database_metrics(db).instrument(span));
 }

crates/autopilot/src/run.rs

@@ -171,17 +171,22 @@ pub async fn run(args: Arguments, shutdown_controller: ShutdownController) {
         .await
         .unwrap();
 
-    let db_read = if let Some(db_read_url) = args.db_read_url
+    let (db_read, run_analyze) = if let Some(db_read_url) = args.db_read_url
         && args.db_write_url != db_read_url
     {
-        Postgres::new(db_read_url.as_str(), args.insert_batch_size)
-            .await
-            .expect("failed to create read replica database")
+        (
+            Postgres::new(db_read_url.as_str(), args.insert_batch_size)
+                .await
+                .expect("failed to create read replica database"),
+            // If the DB is in read-only mode, running ANALYZE is not possible and will trigger and
+            // error https://www.postgresql.org/docs/current/hot-standby.html
+            false,
+        )
     } else {
-        db_write.clone()
+        (db_write.clone(), true)
     };
 
-    crate::database::run_database_metrics_work(db_read.clone());
+    crate::database::run_database_metrics_work(db_read.clone(), run_analyze);
 
     let http_factory = HttpClientFactory::new(&args.http_client);
     let web3 = shared::ethrpc::web3(