Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Token Approval Amount on Confirmation Screen #5389

Open
vnaysngh opened this issue Feb 4, 2025 · 2 comments
Open

Show Token Approval Amount on Confirmation Screen #5389

vnaysngh opened this issue Feb 4, 2025 · 2 comments
Labels
On_hold There's unresolved blockers.

Comments

@vnaysngh
Copy link
Contributor

vnaysngh commented Feb 4, 2025

Description

Currently, when users approve a token for trading, USDT in this case, the approval amount is not displayed on the confirmation screen. This can lead to confusion, as the default approval amount in MetaMask is often unlimited. If users want to set a custom approval amount, they need to manually check the token amount from the main screen before entering it in the MetaMask popup.

Steps to Reproduce

  1. Connect the wallet to Sepolia.
  2. Initiate a token trade that requires approval.
  3. Proceed to the approval step.
  4. Notice that the approval amount is not displayed on the confirmation screen.
  5. In the MetaMask popup, the default approval is unlimited, and users have to manually reference the trade screen for a custom amount.

Expected Behavior (can choose between 1 and 2)

  1. The approval amount displayed in the MetaMask popup should match the amount entered on the swap screen.
  2. The approval screen should display the exact amount being approved so users can easily reference it when setting a custom amount in MetaMask.

Screenshot
Image

Additional Context
• Adding this information improves transparency and reduces the risk of unintentionally approving an unlimited amount.
• Users should not have to navigate back and forth to confirm the correct token amount for approval.

@vnaysngh
Copy link
Contributor Author

vnaysngh commented Feb 4, 2025

Image

@elena-zh
Copy link
Contributor

elena-zh commented Feb 4, 2025

Hey @vnaysngh , your proposal is great!

But for now, we are sending unlimited amount to approve a token, so there is no point in showing it on the Confirm screen.

As for partial approvals, this feature is included into the roadmap and will be implemented in the near future.

Thanks.

@elena-zh elena-zh added the On_hold There's unresolved blockers. label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On_hold There's unresolved blockers.
Projects
None yet
Development

No branches or pull requests

2 participants