feat(atomic): improve atomic-tab overflow behaviour #4725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
fpbrault
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
fpbrault
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
fpbrault
had a problem deploying
to
PR Artifacts
GitHub Actions
Error
fpbrault
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
fpbrault
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fpbrault
requested review from
olamothe,
y-lakhdar,
fbeaudoincoveo and
alexprudhomme
alexprudhomme
approved these changes
Nov 28, 2024
packages/atomic/src/components/search/tabs/atomic-tab-manager/atomic-tab-manager.tsx
Show resolved
Hide resolved
fbeaudoincoveo
approved these changes
Nov 28, 2024
fpbrault
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the way overflow is handled on atomic tabs. Instead of a dropdown on small screen widths, tabs overflow in a dropdown. Additionally, when not enough space is available to display tabs, they will get truncated as needed.
https://coveord.atlassian.net/browse/KIT-3732