Skip to content

Commit d4d3354

Browse files
committed
solution without dropdown
1 parent c23ae85 commit d4d3354

File tree

5 files changed

+6
-94
lines changed

5 files changed

+6
-94
lines changed

packages/atomic/src/components/common/tab-manager/tab-dropdown-option.tsx

Lines changed: 0 additions & 22 deletions
This file was deleted.

packages/atomic/src/components/common/tab-manager/tab-dropdown.tsx

Lines changed: 0 additions & 42 deletions
This file was deleted.

packages/atomic/src/components/common/tab-manager/tab-manager-bar.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ export class TabManagerBar {
185185

186186
public render = () => {
187187
return (
188-
<Host>
188+
<Host class="overflow-x-clip overflow-y-visible">
189189
<slot></slot>
190190
<tab-popover>{this.popoverTabs}</tab-popover>
191191
</Host>

packages/atomic/src/components/common/tab-manager/tab-button.tsx renamed to packages/atomic/src/components/common/tab-manager/tab-manager-button.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,13 @@ export class TabManagerButton {
3636
return (
3737
<Host
3838
role="listitem"
39-
class={`${this.activeTabClass}`}
39+
class={`${this.activeTabClass} max-w-[50%] sm:max-w-full`}
4040
aria-current={this.active ? 'true' : 'false'}
4141
aria-label={'tab for ' + this.label}
4242
part="button-container"
4343
>
4444
<button
45-
class={`w-full px-6 pb-1 text-xl ${this.activeTabTextClass}`}
45+
class={`w-full truncate px-2 pb-1 text-xl sm:px-6 ${this.activeTabTextClass}`}
4646
part="tab-button"
4747
onClick={this.select}
4848
>

packages/atomic/src/components/search/tabs/atomic-tab-manager/atomic-tab-manager.tsx

Lines changed: 3 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@ import {
1010
BindStateToController,
1111
InitializeBindings,
1212
} from '../../../../utils/initialization-utils';
13-
import {TabDropdown} from '../../../common/tab-manager/tab-dropdown';
14-
import {TabDropdownOption} from '../../../common/tab-manager/tab-dropdown-option';
1513
import {Bindings} from '../../atomic-search-interface/atomic-search-interface';
1614

1715
/**
@@ -90,42 +88,20 @@ export class AtomicTabManager {
9088
role="list"
9189
aria-label="tab-area"
9290
part="tab-area"
93-
class="mb-2 flex hidden w-full flex-row border-b sm:flex"
91+
class="mb-2 flex w-full flex-row border-b"
9492
>
9593
{this.tabs.map((tab) => (
96-
<Tab-Manager-Button
94+
<tab-manager-button
9795
active={this.tabManagerState.activeTab === tab.name}
9896
label={tab.label}
9997
select={() => {
10098
if (!tab.tabController.state.isActive) {
10199
tab.tabController.select();
102100
}
103101
}}
104-
></Tab-Manager-Button>
102+
></tab-manager-button>
105103
))}
106104
</div>
107-
<div class="w-full sm:hidden">
108-
<TabDropdown
109-
tabs={this.tabs}
110-
activeTab={this.tabManagerState.activeTab}
111-
onTabChange={(e) => {
112-
const selectedTab = this.tabs.find(
113-
(tab) => tab.name === (e as string)
114-
);
115-
if (selectedTab) {
116-
selectedTab.tabController.select();
117-
}
118-
}}
119-
>
120-
{this.tabs.map((tab) => (
121-
<TabDropdownOption
122-
value={tab.name}
123-
label={tab.label}
124-
isSelected={tab.name === this.tabManagerState.activeTab}
125-
/>
126-
))}
127-
</TabDropdown>
128-
</div>
129105
</tab-manager-bar>
130106
</Host>
131107
);

0 commit comments

Comments
 (0)