Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bots, dapps have duplicate code #7

Open
ldct opened this issue Apr 29, 2019 · 5 comments
Open

Bots, dapps have duplicate code #7

ldct opened this issue Apr 29, 2019 · 5 comments
Assignees

Comments

@ldct
Copy link
Member

ldct commented Apr 29, 2019

The following files are very similar:

  • packages/high-roller-bot/src/utils.ts
  • packages/tic-tac-toe-bot/src/utils.ts
@cf19drofxots
Copy link
Member

This branch is the placeholder for the work that consolidates the bot packages into a single package that'll be a library for writing bots.

@ldct
Copy link
Member Author

ldct commented Apr 29, 2019

Deduping the code should be faster than writing a new library IMO

@cf19drofxots
Copy link
Member

I mean since they're using the exact same code, you could just pull that out but wherever you place it for both of them to fetch it would essentially make that new place a (not-well-thought-out) library, no?

@ldct
Copy link
Member Author

ldct commented Apr 29, 2019

OK, let me reword: "pulling out the duplicate code" into a not-well-thought-out library, is faster than waiting for branch cf_bot to be merged.

@cf19drofxots
Copy link
Member

Yeah, that's true

@joelalejandro joelalejandro transferred this issue from counterfactual/monorepo Aug 9, 2019
@Alonski Alonski self-assigned this Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants