Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[High Roller & TicTacToe] Use @counterfactual/apps for dapps #23

Open
Alonski opened this issue Sep 5, 2019 · 0 comments
Open

[High Roller & TicTacToe] Use @counterfactual/apps for dapps #23

Alonski opened this issue Sep 5, 2019 · 0 comments
Assignees
Labels

Comments

@Alonski
Copy link
Member

Alonski commented Sep 5, 2019

Currently, in the High Roller and Tic Tac Toe dapps the Contract addresses are hard coded or partially hard coded. This is very error prone especially now that the dapps are in a different repo.

What we currently have:

High Roller currently hard codes the address:

https://github.com/counterfactual/dapps-bots/blob/master/packages/dapp-high-roller/src/components/app-root/app-root.tsx#L206

Tic Tac Toe gets the address using @counterfactual/apps however it hardcodes the network:

https://github.com/counterfactual/dapps-bots/blob/master/packages/dapp-tic-tac-toe/src/Wager.jsx#L78

The flaw with the TTT method is that the network used is hard coded. We can probably figure this out from MetaMask or another method.

What needs to be done:

We need to update High Roller to also use @counterfactual/apps
Then we need to update both dapps to get the network dynamically and act accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant