Skip to content
This repository has been archived by the owner on Nov 29, 2024. It is now read-only.

Decouple the abi files #87

Closed
srdtrk opened this issue Jul 31, 2024 · 1 comment
Closed

Decouple the abi files #87

srdtrk opened this issue Jul 31, 2024 · 1 comment
Labels
contracts Issues concerning the solidity contracts enhancement New feature or request needs discussion This issue needs more discussion before its implementation nice to have

Comments

@srdtrk
Copy link
Member

srdtrk commented Jul 31, 2024

Right now, all the required abi are generated in the single file contracts/abi/SP1ICS07Tendermint.json. I often find myself adding new structs to the public api using apiPublicTypes function.

It should be possible to get rid of this function by breaking down the abi to different json files for each interface contract
@srdtrk srdtrk added enhancement New feature or request nice to have contracts Issues concerning the solidity contracts labels Jul 31, 2024
@srdtrk srdtrk changed the title Decouple the abi definitions Decouple the abi files Jul 31, 2024
@srdtrk srdtrk added the needs discussion This issue needs more discussion before its implementation label Aug 13, 2024
@srdtrk srdtrk mentioned this issue Nov 29, 2024
Open
@srdtrk
Copy link
Member Author

srdtrk commented Nov 29, 2024

issue moved to cosmos/solidity-ibc-eureka#131

@srdtrk srdtrk closed this as completed Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
contracts Issues concerning the solidity contracts enhancement New feature or request needs discussion This issue needs more discussion before its implementation nice to have
Projects
IBC-GO Eureka
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@srdtrk