Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escrow Account Management #6

Closed
2 tasks
sangier opened this issue Jul 31, 2024 · 1 comment · Fixed by #74
Closed
2 tasks

Escrow Account Management #6

sangier opened this issue Jul 31, 2024 · 1 comment · Fixed by #74
Assignees
Labels
20-transfer Issues related to the ICS20 application type: feature Feature request
Milestone

Comments

@sangier
Copy link
Contributor

sangier commented Jul 31, 2024

  • Research how to manage escrow account

  • Implement escrow account management.

  • Serdar comment: Right now, we don't have an escrow, but the app should work good enough for testing.

@srdtrk srdtrk added the type: feature Feature request label Aug 3, 2024
@srdtrk
Copy link
Member

srdtrk commented Aug 15, 2024

We might want to go in the direction of yui-ibc-solidity and introduce an escrow contract (similar to bank keeper). Thanks for this suggestion @gjermundgaraba. This would help with:

  1. Migration: Right now, all escrow tokens are held by ICS20Transfer.sol. Since we plan to introduce migrations via proxy contracts in [EPIC] Support migrations and recoveries in IBC contracts #12, it would make more sense for there to be a separate escrow manager contract that manages the escrow. This way, we can migrate ICS20 without moving the escrowed funds.

  2. Modularity: Right now, ICS20Transfer.sol handles the conversions between ERC20 and SdkCoin via the SdkCoin.sol library. This is not ideal since this ICS20Transfer.sol implementation would only be usable between ERC20 and Cosmos. It might make more sense to move this layer to the escrow contract. But this still needs more research.

@crodriguezvega crodriguezvega added the 20-transfer Issues related to the ICS20 application label Aug 18, 2024
@crodriguezvega crodriguezvega added this to the v1 alpha milestone Aug 20, 2024
@crodriguezvega crodriguezvega moved this to Todo 🏃 in IBC Eureka Aug 30, 2024
@crodriguezvega crodriguezvega self-assigned this Sep 8, 2024
@crodriguezvega crodriguezvega moved this from Todo 🏃 to In Progress 👷 in IBC Eureka Sep 10, 2024
@crodriguezvega crodriguezvega linked a pull request Sep 10, 2024 that will close this issue
@crodriguezvega crodriguezvega removed their assignment Sep 23, 2024
@srdtrk srdtrk closed this as completed in #74 Oct 7, 2024
@github-project-automation github-project-automation bot moved this from In Progress 👷 to Done 🥳 in IBC Eureka Oct 7, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in IBC-GO Eureka Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
20-transfer Issues related to the ICS20 application type: feature Feature request
Projects
Status: Done
Status: Done 🥳
3 participants