Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move message validation logic to msg_server.go #2149

Open
mpoke opened this issue Aug 19, 2024 · 0 comments
Open

Move message validation logic to msg_server.go #2149

mpoke opened this issue Aug 19, 2024 · 0 comments
Labels
good first issue Good for newcomers scope: cosmos-sdk Integration with Cosmos SDK type: tech-debt Slows down development in the long run

Comments

@mpoke
Copy link
Contributor

mpoke commented Aug 19, 2024

Problem

ValidateBasic is deprecated (both in v47 and v50). This is a "soft" deprecation, but to avoid future issues, it would be preferable to move the logic directly into the message server handling.

Closing criteria

The message validation logic is moved to msg_server.go.
@mpoke mpoke added scope: cosmos-sdk Integration with Cosmos SDK type: tech-debt Slows down development in the long run labels Aug 19, 2024
@github-project-automation github-project-automation bot moved this to 🩹 F1: Triage in Cosmos Hub Aug 19, 2024
@mpoke mpoke moved this from 🩹 F1: Triage to 📥 F2: Todo in Cosmos Hub Aug 19, 2024
@mpoke mpoke added the good first issue Good for newcomers label Sep 17, 2024
@mpoke mpoke mentioned this issue Sep 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers scope: cosmos-sdk Integration with Cosmos SDK type: tech-debt Slows down development in the long run
Projects
Cosmos Hub
Status: 📥 F2: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mpoke