Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to cosmos-sdk appmodule.Environment in ibc #7712

Closed
6 of 10 tasks
damiannolan opened this issue Dec 17, 2024 · 0 comments · Fixed by #7880
Closed
6 of 10 tasks

Migrate to cosmos-sdk appmodule.Environment in ibc #7712

damiannolan opened this issue Dec 17, 2024 · 0 comments · Fixed by #7880
Assignees
@technicallyty
Labels
type: code hygiene Clean up code but without changing functionality or interfaces type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone
v10.0.0

Comments

@damiannolan
Copy link
Contributor

damiannolan commented Dec 17, 2024 •
edited by technicallyty
Loading

Summary

Follow up issue from Olympus upgrade (#7223)

With upgrading to cosmos-sdk v0.52 we will leverage the service based Environment architecture where possible, rather than relying on the legacy sdk.Context approach.

This refactor was already started with icacontroller in order to get the bulk of the Olympus upgrade merged to main. This issue serves to track the remainder of modules and submodules as we migrate to appmodule.Environment.

  • icacontroller
  • icahost
  • fee middleware
  • transfer
  • core
  • lightclients (solomachine, tendermint, localhost, wasm)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
  • Estimate provided
@damiannolan damiannolan added type: code hygiene Clean up code but without changing functionality or interfaces type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. labels Dec 17, 2024
@damiannolan damiannolan added this to the v10.0.0 milestone Dec 17, 2024
@damiannolan damiannolan self-assigned this Dec 17, 2024
@damiannolan damiannolan moved this from Backlog to In progress in IBC-GO Eureka Dec 17, 2024
@damiannolan damiannolan mentioned this issue Dec 17, 2024
Merged
10 tasks
@DimitrisJim DimitrisJim mentioned this issue Dec 17, 2024
Open
4 tasks
This was referenced Dec 18, 2024
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Closed
@gjermundgaraba gjermundgaraba self-assigned this Jan 5, 2025
This was referenced Jan 5, 2025
Draft
Closed
@technicallyty technicallyty mentioned this issue Jan 24, 2025
Merged
10 tasks
@technicallyty technicallyty linked a pull request Jan 24, 2025 that will close this issue
chore: use context.Context and appmodule.Environment in 08-wasm #7880
Merged
10 tasks
@github-project-automation github-project-automation bot moved this from In progress to Done in IBC-GO Eureka Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@technicallyty technicallyty

Labels
type: code hygiene Clean up code but without changing functionality or interfaces type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
IBC-GO Eureka
Status: Done
Milestone
v10.0.0
Development

Successfully merging a pull request may close this issue.

chore: use context.Context and appmodule.Environment in 08-wasm cosmos/ibc-go
3 participants
@gjermundgaraba @damiannolan @technicallyty