Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SetMultiAcknowledgement to PacketServerKeeper #7251

Open
4 tasks
chatton opened this issue Sep 4, 2024 · 2 comments
Open
4 tasks

Move SetMultiAcknowledgement to PacketServerKeeper #7251

chatton opened this issue Sep 4, 2024 · 2 comments

Comments

@chatton
Copy link
Contributor

chatton commented Sep 4, 2024

Summary

SetMultiAcknowledgement is currently on the channel keeper.

With Eureka, we won't want to me adding new functionality onto the Channel Keeper, so it makes sense to move this onto the PacketServerKeeper instead.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
  • Estimate provided
@chandiniv1
Copy link
Contributor

@chatton can I work on this issue?

@DimitrisJim
Copy link
Contributor

as a heads up @chandiniv1 many of the issues tagged with feat: port-router might possibly be stale at the moment. We are currently in the process of closing any of these up!

Sorry for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants