Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasm and callbacks binaries should be generated from main simapp #7231

Open
colin-axner opened this issue Aug 29, 2024 · 1 comment · May be fixed by #7445
Open

wasm and callbacks binaries should be generated from main simapp #7231

colin-axner opened this issue Aug 29, 2024 · 1 comment · May be fixed by #7445
Labels
type: productivity Increase dev productivity and throughput by improving developer tooling, infrastructure, automation

Comments

@colin-axner
Copy link
Contributor

The 08-wasm and callback modules should have binaries which are generated using the main simapp, rather than containing duplicate logic to create a binary. The main simapp is used for e2e's and is not imported by the ibc-go module

Originally posted by @colin-axner in #6710 (comment)
@crodriguezvega crodriguezvega added the type: productivity Increase dev productivity and throughput by improving developer tooling, infrastructure, automation label Sep 1, 2024
@colin-axner colin-axner moved this to Backlog 🕐 in ibc-go Sep 5, 2024
@colin-axner colin-axner linked a pull request Oct 14, 2024 that will close this issue
Open
10 tasks
@colin-axner
Copy link
Contributor Author

colin-axner commented Oct 15, 2024 •
edited
Loading

I will split this work up, for each wasm and callbacks:

  • add them into top level simapp
  • remove duplicated workflows and use workflows against top level simapp
  • remove duplicated simd + Dockerfiles

@colin-axner colin-axner mentioned this issue Oct 22, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: productivity Increase dev productivity and throughput by improving developer tooling, infrastructure, automation
Projects
ibc-go
Status: Backlog 🕐
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove unnecessary deps from 08-wasm by reusing top level simapp binary cosmos/ibc-go
2 participants
@crodriguezvega @colin-axner