Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining Stage 1 issues #656

Open
patudom opened this issue Oct 15, 2024 · 3 comments · May be fixed by #664
Open

Remaining Stage 1 issues #656

patudom opened this issue Oct 15, 2024 · 3 comments · May be fixed by #664
Assignees

Comments

@patudom
Copy link
Contributor

patudom commented Oct 15, 2024

Somethings I noticed that should be fixed in a later PR (that exist on main as well) are

  1. that the velocity for the real galaxies does not update if the student changes their measurement, they would have to press the fill velocities button. We either want to prevent changes, or automatically update them.
  2. Selecting the galaxy does not seem to put it in the WWT view

Originally posted by @johnarban in #653 (review)

@patudom
Copy link
Contributor Author

patudom commented Oct 15, 2024

Thanks, @johnarban! I'm not sure what's going on with item 2 because that used to work until very recently, so we must have broken it in one of our later PRs. I should have checked before I merged in #653, but was item 2 definitely broken on main before I merged 653?

@johnarban
Copy link
Collaborator

I feel like it wasn't broken before, and that it worked, but that part of the code I don't think has been touched in a while

@patudom
Copy link
Contributor Author

patudom commented Oct 15, 2024

Ok, if it wasn't broken on main before, I might have an idea of what I did in #653 that broke it. I will try to fix it in a new branch. If I don't succeed, I will reach out. Thanks!

@johnarban johnarban linked a pull request Oct 16, 2024 that will close this issue
@patudom patudom self-assigned this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants