Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage 1 nitpicky things to fix #638

Open
11 of 18 tasks
patudom opened this issue Oct 4, 2024 · 2 comments
Open
11 of 18 tasks

Stage 1 nitpicky things to fix #638

patudom opened this issue Oct 4, 2024 · 2 comments
Assignees
Labels
2. complete soon Non-breaking issue that should be fixed or implemented soon

Comments

@patudom
Copy link
Contributor

patudom commented Oct 4, 2024

  • marker sel_gal before-next text does not appear
  • viewer labels should all use the same font. (dotplot & spectrum viewer fonts are not the same).

Spectrum viewer

  • H-alpha (rest) label is too subtle - make it a full vertical line. Also, its location right on the spectrum graph is not really meaningful because it doesn't actually relate to the part of the spectrum that is at that wavelength.
  • Spectrum graph doesn't need a grid background. Update styling to match voila version.
  • Spectrum viewer measuring tool - simplify label. Does not need y value and x value should be rounded and have a unit label
  • dop_cal5 slideshow - any change (like clicking next) causes the whole page to flicker. Is there any way around that? (the reflect velocity slideshow does not seem to trigger this flickering).
  • During dotplot sequence, Spectrum viewer measuring tool becomes a horizontal double arrow instead of a vertical line. It should be a vertical line. @Carifio24 pointed out that that double arrow signifies the ability to pan horizontally, so we need to make sure that the drag mode is false, so you can't pan.

Dotplot sequence

  • Update format of x-axis tick labels to show numbers and not just 40k 80k.
  • We are still not displaying the full range of wonky measurement 1 values for the example galaxy that we used to have.
  • int_dot1 - my measurement dot appears green, not red.
  • dot_seq5 - spectrum viewer displays a vertical measuring line before any corresponding values have been clicked in the dot plot. That is confusing and should be turned off.
  • "my measurement" shown in the spectrum viewer could maybe be a smaller mark similar to the H-alpha observed marker but a different color. The horizontal red line looks too much like the measuring tool lines.
  • Tool button orders in dotplot & spectrum viewer need to be made consistent
  • If you zoom way into a small vel range in dot plot, the green vertical marker has a small y-value because there are fewer dots. When you then zoom out to full x range, its height needs to rescale to the full y-range, otherwise it's tiny.
Screenshot 2024-10-04 at 9 50 18 AM
  • Remove hint/helper text on int_dot1 if we think this is fixed.

  • dot_seq10 does not make sense if you are not zoomed in. Can we force the zoom in to that range on this guideline?

  • dot_seq11 does not have a "next" button. I had to use the state editor to advance.

  • dot_seq9 - changing my wavelength measurement is not updating what is shown in the table. The table is displaying the 2nd measurement here. Do we mean to be displaying the 1st measurement still? It seems like the opportunity to remeasure and see how I did ought to just be the 2nd measurement? And should the dot plot now be displaying the 2nd measurements?

@patudom patudom self-assigned this Oct 4, 2024
@patudom
Copy link
Contributor Author

patudom commented Oct 4, 2024

I will work my way through the items I know how to fix and will pass the rest on to someone else.

@Carifio24
Copy link
Member

Carifio24 commented Oct 8, 2024

During dotplot sequence, Spectrum viewer measuring tool becomes a horizontal double arrow instead of a vertical line. It should be a vertical line. @Carifio24 pointed out that that double arrow signifies the ability to pan horizontally, so we need to make sure that the drag mode is false, so you can't pan.

I think (I haven't tested it) that replacing line 272 in the spectrum viewer with

fig.update_layout(dragmode="zoom" if 0 in toggle_group_state.value else False)

should do the trick

@patudom patudom added the 2. complete soon Non-breaking issue that should be fixed or implemented soon label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. complete soon Non-breaking issue that should be fixed or implemented soon
Projects
None yet
Development

No branches or pull requests

2 participants