nit

Author: YunxianHua

coListener/coListener.py

@@ -196,7 +196,7 @@ def __init__(self):
             self.get_parameter("error_code_topic").get_parameter_value().string_value
         )
 
-        self.declare_parameter("waiting_data_minutes", 10)
+        self.declare_parameter("waiting_data_minutes", 60)
         self.waiting_minutes = (
             self.get_parameter("waiting_data_minutes")
             .get_parameter_value()
@@ -216,9 +216,9 @@ def __init__(self):
         _log.info(
             f"[node params] bag_storage_path: {self.bag_storage_path}, "
             f"error_code_topic: {self.error_code_topic}, "
-            f"waiting_data_minutes: {self.waiting_minutes},"
-            f"use_service: {self.use_service},"
-            f"cos_agent_path: {cos_agent_path},"
+            f"waiting_data_minutes: {self.waiting_minutes}, "
+            f"use_service: {self.use_service}, "
+            f"cos_agent_path: {cos_agent_path}, "
             f"version: {self.version}"
         )
 
@@ -550,9 +550,13 @@ def _write_upload_info_to_cos_state(
             json.dump(info.to_dict(), fp, indent=4)
 
     def _collect_bag_files(self, trigger_time, cache_data):
-        bag_interval_minutes = 2
-        bags_to_upload = []
         bag_files = []
+        bags_to_upload = []
+        bag_interval_minutes = 2
+
+        if not os.path.exists(self.bag_storage_path):
+            return False, bags_to_upload
+
         files = os.listdir(self.bag_storage_path)
         for bag_file in files:
             bag_full_path = os.path.join(self.bag_storage_path, bag_file)
@@ -609,10 +613,14 @@ def _collect_bag_files(self, trigger_time, cache_data):
 
     def _collect_log_files(self):
         log_files = []
+        logs_to_upload = []
         log_directory = os.path.join(
             self.log_storage_path, datetime.datetime.now().strftime("%Y%m%d")
         )
 
+        if not os.path.exists(log_directory):
+            return logs_to_upload
+
         for node_name in os.listdir(log_directory):
             node_log_dir = os.path.join(log_directory, node_name)
             if node_name == "edge_gateway":
@@ -653,7 +661,6 @@ def _collect_log_files(self):
                 if file_to_update != "":
                     log_files.append(file_to_update)
 
-        logs_to_upload = []
         for log_file in log_files:
             logs_to_upload.append(
                 {

coListener/rest.py

@@ -91,8 +91,9 @@ def fetch_rules_version(self) -> Dict[str, int]:
             for project in projects:
                 project_name = str(project["name"])
 
-                version_url = (f"{self.__api_url}/dataplatform/v1alpha2/"
-                               f"{project_name}/diagnosisRule/metadata")
+                version_url = (
+                    "{self.__api_url}/dataplatform/v1alpha2/{project_name}/diagnosisRule/metadata"
+                )
                 ver = self._get_response(version_url, {}).get("currentVersion", -1)
                 rules_version[project_name] = ver
             return rules_version

launch/coListener.launch.py

@@ -22,7 +22,7 @@ def generate_launch_description():
     log_storage_path = "/home/cos/files/logs"
     error_code_topic = "/error_code"
     use_service = False
-    waiting_data_minutes = 60
+    waiting_data_minutes = 10
 
     return LaunchDescription(
         [