Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review use of IConfiguration/IConfigurationRoot #29

Open
2 tasks
idg10 opened this issue Dec 9, 2019 · 0 comments
Open
2 tasks

Review use of IConfiguration/IConfigurationRoot #29

idg10 opened this issue Dec 9, 2019 · 0 comments

Comments

@idg10
Copy link
Contributor

idg10 commented Dec 9, 2019

As per the discussion at corvus-dotnet/Corvus.Identity#13 (comment) we are attempting to move away from using either IConfiguration or IConfigurationRoot in the guts of our IP for the reasons discussed at corvus-dotnet/Corvus.Identity#11

This project currently uses configuration types directly. We need to review whether it runs into the problems described in the links above, and if so, make the relevant changes.

As discussed in the conversation linked to, we have two goals:

  • Avoid any undesirable use of IConfiguration[Root]
  • Review the DI setup requirements to see if there are opportunities to simplify normal usage

If any problems or possibly improvements come to light on the second point, please create new work items for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant