Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that Corvus.Testing.SpecFlow.NUnit metapackage sets IsTestProject to true #230

Open
idg10 opened this issue Mar 24, 2021 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@idg10
Copy link
Contributor

idg10 commented Mar 24, 2021

The Corvus.Testing.SpecFlow.NUnit includes a reference to the Microsoft.NET.Test.Sdk package, which sets the IsTestProject MSBuild variable to true. This has potentially unexpected side effects.

For example, we recently ran into a problem where a project that build a DLL containing test utilities started using this metapackage. This had the side effect that the build process no longer produced NuGet packages for that DLL. This was not the intention—this project was not a test project, it was a library intended to be used from test projects.

It took a while to diagnose this. It's not entirely obvious that Microsoft.NET.Test.Sdk sets IsTestProject, nor that this in turn changes the default value for IsPackable from true to false.

When we add documentation for this project, we should clarify this side effect.

@idg10 idg10 added the documentation Improvements or additions to documentation label Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant