Replies: 3 comments
-
The MIDI notes and pad types should not be set in the code and compiled on the board but should be set using the edrumulus_gui.py tool (see this screen shot). You'll need this tool later on anyway when you have to adjust your threshold, sensitivity, etc. values. |
Beta Was this translation helpful? Give feedback.
-
The MIDI settings are already covered by my first comment. Regarding the pin definitions: Usually, Arduino projects let the user define the project settings in the .ino file. Having to make modifications in the edrumulus_hardware.cpp file is not good, I totally agree with you. I have created a new Git branch improve_hardware_config, where I moved the default pin definition in the header of the .ino file. With this modification, Edrumulus is compatible to other Arduino projects in this regard. Here is are the changes I have done: main...improve_hardware_config |
Beta Was this translation helpful? Give feedback.
-
Cool, thanks I'll close this discussion |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
When testing edrumulus I always have to mess with files like:
I don't any ideas for how to implement this or even if it is feasible(optimisation) but, i feel it should have a file that we can change pins, pads and midi notes in the same place without seen the code :)
So, this should make config and code separate parts and potentially prevents some errors.
Maybe some constants like PIN_SNARE_HEAD , MIDI_SNARE_HEAD, MIDI_CHOKE_CRASH1 and so on...
And if you only configure for example PIN_SNARE_HEAD, MIDI_SNARE_HEAD, PAD_SNARE the code will adapt and only configure one pad. This should prevent some problems with array in edrumulus_hardware.cpp
Thank you again for you work, and hope this can be considared in a future implementation.
Octavio
Beta Was this translation helpful? Give feedback.
All reactions