Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Implement all cells in code #739

Open
2 tasks done
dasdom opened this issue Jun 21, 2020 · 4 comments
Open
2 tasks done

Implement all cells in code #739

dasdom opened this issue Jun 21, 2020 · 4 comments
Assignees
Labels
enhancement Improvement of an existing feature mirrored-to-jira This item is also tracked internally in JIRA

Comments

@dasdom
Copy link
Contributor

dasdom commented Jun 21, 2020

Avoid duplicates

  • This issue has not already been raised before
  • If you are proposing a new feature, please do so in CWA-Wishlist

Current Implementation

CollectionViewCells and TableViewCells are implemented using Xibs.

Suggested Enhancement

CollectionViewCells and TableViewCells should be implemented in code

Expected Benefits

Code is easier to

  • refactor
  • document
  • reason about
  • automate
  • understand

In addition code is less likely to break with Xcode updates.


Internal Tracking ID: EXPOSUREAPP-1954

@dasdom dasdom added the enhancement Improvement of an existing feature label Jun 21, 2020
@inf2381
Copy link
Member

inf2381 commented Jun 23, 2020

Totally agree with you here. We are discussing this topic all the time within the team but we cannot convince some of the developers within the team. I'll keep this issue open until we convinced them. 😐

@tkowark tkowark added the mirrored-to-jira This item is also tracked internally in JIRA label Jul 28, 2020
@ghost ghost assigned MarisaWollner Aug 7, 2020
@ghost ghost assigned hermesmar Sep 29, 2020
@Ein-Tim
Copy link
Contributor

Ein-Tim commented May 17, 2021

Could one of the devs give us an update about this issue which is soon almost a year old?

Or maybe @dasdom would like to take another look at the code and say if the situation has(n't) changed in the meantime?

@dasdom
Copy link
Contributor Author

dasdom commented May 17, 2021

The project still uses simple Xibs for some cells. They seem to be simple and should be easy to replace with code.

Examples:

Screen Shot 2021-05-17 at 21 38 18

Screen Shot 2021-05-17 at 21 40 34

@dsarkar
Copy link
Member

dsarkar commented May 18, 2021

Thanks. Updated internal ticket.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement of an existing feature mirrored-to-jira This item is also tracked internally in JIRA
Projects
None yet
Development

No branches or pull requests

7 participants