Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Stack Segmention Error #1639

Open
zhoualibaba opened this issue Nov 29, 2024 · 6 comments
Open

[Bug] Stack Segmention Error #1639

zhoualibaba opened this issue Nov 29, 2024 · 6 comments
Assignees

Comments

@zhoualibaba
Copy link

zhoualibaba commented Nov 29, 2024

Describe the Bug

I encounter this issue when using Segmentation Tool (labelmap) in the stack viewport. After drawing a ROI at only one specific slice, the ROI would exist at all slices.

I tried 'csToolsSegmentation. state. getCurrentLabelmapiImageIdForViewport' (activeViewportId, 'MY_SGMENTION-ID') and found that function did not change when moving to next slice using StackScrollTool.

I think the reason is that when I changed the image slice, the 'segmentationImageId(derived:9a66f6a5-5411-42d0-b654-9f4a77c133d6)' did not change.

I would like to know if I can change the 'segmentationImageId' myself.

I created an anonymous data for debugging purposes.
sub_with_pid_c.zip

I think the stack viewport may not support certain XA modality data.

Steps to Reproduce

1.use wadouri load this data
2.use BrushTool or RectangleScissorsTool
3.use StackScrollTool

The current behavior

img_v3_02h3_b324ca8e-060f-420f-852f-c6da65d8f80g

The expected behavior

d

OS

d

Node version

d

Browser

d

Copy link
Member

sedghi commented Dec 2, 2024

This is probably an issue with the metadata, likely all the frames have the same imagePositionPatient. Is this multiframe data?

@zhoualibaba
Copy link
Author

zhoualibaba commented Dec 3, 2024

@sedghi Yse, this is multiframe data,but there is no imagePositionPatient tag in the metadata.

Most XA modality data does not have this tag. Perhaps Cornerstone think that metadata contains the same imagePositionPatient.
I tried CT data with imagePositionPatient tag in STACK(wadouri) viewport,it works well. I think you are right. So i want to know is there any way to solve this problem .I think it is important for STACK viewport.

I also find that if the metadata contains ImageOrientationPatient tag, the segmentationTool does not work, as reported at [Bug] Stack Labelmap Segmentation error #1591 .

I would like to know if I can change the 'segmentationImageId' I am using myself.Like viewport.setImageIdIndex(6).

@IbrahimCSAE
Copy link
Collaborator

IbrahimCSAE commented Dec 6, 2024

I cant really replicate this in latest ohif @sedghi

viewer-dev.ohif.org/local

CleanShot.2024-12-06.at.09.09.47.mp4

@zhoualibaba
Copy link
Author

zhoualibaba commented Dec 8, 2024

I want to know if OHIF did anything special to handle it.
I load data and use SegmentationTools like Segmentation in StackViewport.

The different is i use wadouri for loading data.
Use
await prefetchMetadataInformation(imageIds)
imageIds = convertMultiframeImageIds(imageIds)

@sedghi sedghi closed this as completed Dec 11, 2024
@zhoualibaba
Copy link
Author

@sedghi I tried the latest version, but the problem still exist.
I think this issue is not the same as #1591

@sedghi sedghi reopened this Dec 13, 2024
Copy link
Member

sedghi commented Dec 13, 2024

I opened it , but since it is working (at least in OHIF) it is not a priority for us, you can look at OHIF code to see what is happening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants