feat: add new formatter log output for github #59
Conversation
fzipi
force-pushed
the
add-github-zerolog-output
branch
2 times, most recently
from
c343cf2
to
f2418cf
Compare
fzipi
force-pushed
the
add-github-zerolog-output
branch
from
9eaefbd
to
9ea579c
Compare
fzipi
force-pushed
the
add-github-zerolog-output
branch
from
8891875
to
932d12b
Compare
|
@theseion Looks like test is failing (cmd/regex_compare_test.go:151) because the error was not triggered per |
Signed-off-by: Felipe Zipitria <[email protected]>
Signed-off-by: Felipe Zipitria <[email protected]>
Signed-off-by: Felipe Zipitria <[email protected]>
fzipi
force-pushed
the
add-github-zerolog-output
branch
from
932d12b
to
58bbb52
Compare
| } | ||
|
|
||
| func (s *loggerTestSuite) TestConsoleOutput() { | ||
| s.logger = s.logger.Output(zerolog.ConsoleWriter{Out: s.out, NoColor: true, TimeFormat: "03:04:05"}) |
There was a problem hiding this comment.
Instead of configuring the console output here explicitly for the test, wouldn't it be better to have an additional choice to generate JSON output? Just like you did now for GH.
There was a problem hiding this comment.
Did you mean console output? JSON is the default. Do you want something like SetConsoleOutput?
There was a problem hiding this comment.
Zerolog's default is JSON, but our global logger is configured to use the console writer. So for users, currently, there's only the option of either console or GH optimised output. I don't see the point in testing JSON output if we don't offer it to users.
Signed-off-by: Felipe Zipitria [email protected]
Modify logger to output in a format parseable by Github's runners.
Fixes #56.
Pending: