Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kdump to an NFS share require additional configuration (was: Consider adding NFS module to initramfs) #1729

Open
jbtrystram opened this issue May 14, 2024 · 13 comments
Assignees

Comments

@jbtrystram
Copy link
Contributor

Currently, the nfs kernel module is excluded from initramfs as we don't support root on NFS.
However, this prevents kdump to use NFS as a target for logs.

So maybe we could add back that module, or find a way to enable it only in the kdump case ?

See https://issues.redhat.com/browse/OCPBUGS-31755

@travier
Copy link
Member

travier commented May 31, 2024

@jbtrystram
Copy link
Contributor Author

jbtrystram commented May 31, 2024

yes we explicitely omit it there that's why I opened this

@gursewak1997
Copy link
Member

Discussed in the community meeting
This issue should be discussed/fixed with upstream kdump maintainers i.e. i.e. the fix here isn't in our stack, but upstream.

@jbtrystram jbtrystram added the jira for syncing to jira label Jun 24, 2024
@travier travier changed the title consider adding NFS module to initramfs Consider adding NFS module to initramfs Jun 27, 2024
@travier
Copy link
Member

travier commented Jun 27, 2024

We should document how to workaround this issue for kdump.

It should be possible to force the inclusion of the nfs module in the kdump initramfs by passing the --force-add nfs argument to the dracut call via the dracut_args config option in kdump.conf.

@jbtrystram
Copy link
Contributor Author

jbtrystram commented Jul 1, 2024

@travier another easy way is just to add extra_modules nfs to kdump.conf

Surprisingly dracut_args does not work while extra-modules does. See rhkdump/kdump-utils#11 (comment)

@travier
Copy link
Member

travier commented Jul 1, 2024

We should document how to workaround this issue for kdump.

It should be possible to force the inclusion of the nfs module in the kdump initramfs by passing the --force-add nfs argument to the dracut call via the dracut_args config option in kdump.conf.

Apparently this does not work and is tracked in https://issues.redhat.com/browse/RHEL-26114

@travier travier changed the title Consider adding NFS module to initramfs kdump to an NFS share require additional configuration (was: Consider adding NFS module to initramfs) Jul 1, 2024
@travier
Copy link
Member

travier commented Jul 1, 2024

We should add a test for this case.

@jbtrystram jbtrystram self-assigned this Jul 2, 2024
@jbtrystram
Copy link
Contributor Author

@travier
Copy link
Member

travier commented Sep 13, 2024

Might be needed related as well: https://gitlab.com/fedora/bootc/base-images/-/merge_requests/32

jbtrystram added a commit to jbtrystram/coreos-assembler that referenced this issue Oct 22, 2024
This way we have good coverage of most-used kdump features.
Some context on the NFS kdump configuration coreos/fedora-coreos-tracker#1729
jbtrystram added a commit to coreos/coreos-assembler that referenced this issue Oct 23, 2024
This way we have good coverage of most-used kdump features.
Some context on the NFS kdump configuration coreos/fedora-coreos-tracker#1729
jbtrystram added a commit to jbtrystram/coreos-assembler that referenced this issue Nov 3, 2024
This way we have good coverage of most-used kdump features.
Some context on the NFS kdump configuration:
coreos/fedora-coreos-tracker#1729

This was previously merged in [1] then reverted in [2] because the nfs
server container was not multi-arch, causing the pipeline to trip on it.

It's also not functionning on systemd256 (so anything f41 and above),
see [3]

This requires coreos#3917 for
the multi-arch container, and
coreos#3921

[1] coreos@b10d8dc
[2] coreos@af1468c
[3] rhkdump/kdump-utils#52
jbtrystram added a commit to jbtrystram/coreos-assembler that referenced this issue Nov 3, 2024
This way we have good coverage of most-used kdump features.
Some context on the NFS kdump configuration:
coreos/fedora-coreos-tracker#1729

This was previously merged in [1] then reverted in [2] because the nfs
server container was not multi-arch, causing the pipeline to trip on it.

It's also not functionning on systemd256 (so anything f41 and above),
see [3]

This requires coreos#3917 for
the multi-arch container, and
coreos#3921

[1] coreos@b10d8dc
[2] coreos@af1468c
[3] rhkdump/kdump-utils#52
@licliu
Copy link

licliu commented Nov 13, 2024

Hi @jbtrystram @travier, I'd like to fix this issue in kdump rhkdump/kdump-utils#31, but as I commented in rhkdump/kdump-utils#11 (comment), CoreOS's dracut conf may override most dracut varaiables. I suggest to rename them to something like "90-xxxx.conf". Or starting by dracut-104 dracut-ng/dracut-ng@ae81535, --add-confdir is supported, you can move CoreOS specific dracut confs to /usr/lib/dracut/dracut.conf.d/coreos and then use dracut --add-confdir coreos to build initramfs.

@daveyoung
Copy link

Hi, I think the dracut config file name issue should be a separate issue, here is a new one created for that: #1837

@jbtrystram
Copy link
Contributor Author

@licliu @daveyoung I've seen your comments here and in the kexdc-tools issue, but I am away from work for another week. Thanks for looking into that.
I'll do some testing when I am back if no one else from the coreOS team have the time until then

@daveyoung
Copy link

@jbtrystram Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants