Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest additional keyfile/passphrase when using TPM-pinned encryption in single node case #400

Open
jlebon opened this issue May 2, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jlebon
Copy link
Member

jlebon commented May 2, 2022

Both the RHEL docs (see the WARNING boxes) and https://wiki.archlinux.org/title/Trusted_Platform_Module#Clevis recommend setting a strong passphrase when using TPM pinning.

This can be done using storage.luks.keyFile in the Ignition config, but if the Ignition config cannot be secured we should also document doing it manually using cryptsetup luksAddKey once the host is up.

@bgilbert
Copy link
Contributor

bgilbert commented May 3, 2022

Both of those warnings seem to be concerned with sealing to PCR values, which we don't currently do.

I agree that we should document the consequences of only using TPM pinning (if you lose your motherboard, you lose your data), and that we should suggest alternatives (Tang and static keys). But I don't think we should recommend a backup passphrase. FCOS is still primarily targeted at clusters, which should be able to handle the complete loss of a node. And as you point out, there are security implications of putting a key in the Ignition config; it's cleaner and more secure to use Tang.

@jlebon
Copy link
Member Author

jlebon commented May 3, 2022

You're right re. PCR sealing. I learned about that bit shortly after filing this issue.

But I don't think we should recommend a backup passphrase. FCOS is still primarily targeted at clusters, which should be able to handle the complete loss of a node. And as you point out, there are security implications of putting a key in the Ignition config; it's cleaner and more secure to use Tang.

Yeah, it makes less sense in a cluster context. I was thinking more of the single node case. The protection offered by TPM pinning might be good enough and Tang might be too much work to setup. I'll retitle this issue.

@jlebon jlebon changed the title Recommend adding a backup passphrase when using TPM-pinned encryption Suggest additional keyfile/passphrase when using TPM-pinned encryption in single node case May 3, 2022
@travier travier added enhancement New feature or request good first issue Good for newcomers labels Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants