-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect "no action items from last meeting" suggestion #50
Comments
Interesting, I suspect its because of the format change over from matrix? |
I know the regex needs to be checked/updated to ensure that the action works with the new matrix bot. Since any changes could cause the regex to not find any action items. |
With the latest changes, it seems we are still encountering an issue with the latest code. 'Failed: to get action items, check the last meeting notes.' This looks like we are bailing when fetching. So while fetching, lets also at the minimum improve the error to direct to the correct URL. To manually check. |
Also while looking at the action, lets see about improving how it generates the URL. Currently its fairly fragile and simply going back 7 days from the date. This was due to data storage changes the new matrix bot uses now. Put simply the new bot adds another directory which is a date. |
With the latest change, we had to introduce a very fragile concept. Where we looked 7 days prior to capture the last weeks meeting. Instead remove this, and iterate through each folder to capture the last meeting. More work but should reduce fragileness. Additonally action items were not being correctly matched. Update regex for actionItems. fixes: coreos#50
With the latest change, we had to introduce a very fragile concept. Where we looked 7 days prior to capture the last weeks meeting. Instead remove this, and iterate through each folder to capture the last meeting. More work but should reduce fragileness. Additonally action items were not being correctly matched. Update regex for actionItems. fixes: coreos#50
With the latest change, we had to introduce a very fragile concept. Where we looked 7 days prior to capture the last weeks meeting. Instead remove this, and iterate through each folder to capture the last meeting. More work but should reduce fragileness. Additonally action items were not being correctly matched. Update regex for actionItems. fixes: coreos#50
With the latest change, we had to introduce a very fragile concept. Where we looked 7 days prior to capture the last weeks meeting. Instead remove this, and iterate through each folder to capture the last meeting. More work but should reduce fragileness. Additonally action items were not being correctly matched. Update regex for actionItems. fixes: coreos#50
With the latest change, we had to introduce a very fragile concept. Where we looked 7 days prior to capture the last weeks meeting. Instead remove this, and iterate through each folder to capture the last meeting. More work but should reduce fragileness. Additonally action items were not being correctly matched. Update regex for actionItems. fixes: coreos#50
With the latest change, we had to introduce a very fragile concept. Where we looked 7 days prior to capture the last weeks meeting. Instead remove this, and iterate through each folder to capture the last meeting. More work but should reduce fragileness. Additonally action items were not being correctly matched. Update regex for actionItems. fixes: coreos#50
In https://discussion.fedoraproject.org/t/fedora-coreos-community-meeting-minutes-2023-11-22/96760, we got two action items and they were not reported in #49 and got dropped.
The text was updated successfully, but these errors were encountered: