Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kola: --multiply on a test with subtests doesn't work #3873

Open
dustymabe opened this issue Sep 12, 2024 · 0 comments
Open

kola: --multiply on a test with subtests doesn't work #3873

dustymabe opened this issue Sep 12, 2024 · 0 comments

Comments

@dustymabe
Copy link
Member

dustymabe commented Sep 12, 2024

When calling kolet the test name gets passed in mangled. I was able to see this with a small patch:

$ git diff mantle/kola/cluster/cluster.go
diff --git a/mantle/kola/cluster/cluster.go b/mantle/kola/cluster/cluster.go
index 24f3bce03..ce1898628 100644
--- a/mantle/kola/cluster/cluster.go
+++ b/mantle/kola/cluster/cluster.go
@@ -75,6 +75,7 @@ func (t *TestCluster) RunLogged(name string, f func(c TestCluster)) bool {
 // RunNative runs a registered NativeFunc on a remote machine
 func (t *TestCluster) RunNative(funcName string, m platform.Machine) bool {
        command := fmt.Sprintf("./kolet run %q %q", t.H.Name(), funcName)
+       t.Logf("command is %s", command)
        return t.Run(funcName, func(c TestCluster) {
                client, err := m.SSHClient()
                if err != nil {

and then running a simple --multiply=2 basic:

kola -p qemu run --multiply=2 basic --output-dir tmp/kola                                                             
⏭️   Skipping kola test pattern "fcos.internet":           
  👉 https://github.com/coreos/coreos-assembler/pull/1478                                                             
  👉 https://github.com/coreos/coreos-assembler/pull/1478                                                             
⏭️   Skipping kola test pattern "podman.workflow":                                                                    
  👉 https://github.com/coreos/coreos-assembler/pull/1478                                                             
🕒  Snoozing kola test pattern "ext.config.kdump.crash" until Sep 16 2024                                             
  👉 https://github.com/coreos/fedora-coreos-tracker/issues/1791                                                      
=== RUN   basic0                                           
=== RUN   basic1                                           
=== RUN   basic0/ReadOnly                                  
=== RUN   basic0/Useradd                                   
=== RUN   basic0/MachineID                                 
=== RUN   basic0/FCOSGrowpart                              
=== RUN   basic0/PortSSH                                   
=== RUN   basic0/DbusPerms                                 
=== RUN   basic0/ServicesActive                            
--- FAIL: basic0 (27.21s)                                  
        cluster.go:78: command is ./kolet run "basic0" "ReadOnly"                                                     
        cluster.go:96: kolet:                              
Usage:                                                     
  kolet run [test] [func] [flags]                          
  kolet run [command]                                      

Available Commands:                                        
  basic 

Note that kolet should have been called with ./kolet run "basic" "ReadOnly" but the multiplied test name got the appended 0, which appears to be breaking things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant