-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize openshift 4.13.0; create openshift 4.14.0-experimental #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestist
force-pushed
the
openshift-stable
branch
2 times, most recently
from
March 13, 2023 14:57
fb3601b
to
5d7ebb5
Compare
Second commit message has a copypaste error. |
bgilbert
reviewed
Mar 13, 2023
prestist
force-pushed
the
openshift-stable
branch
2 times, most recently
from
March 13, 2023 15:59
5dda166
to
10d3985
Compare
prestist
changed the title
Openshift stable
Stabilize openshift 4.13.0; create openshift 4.14.0-experimental
Mar 13, 2023
prestist
force-pushed
the
openshift-stable
branch
from
March 13, 2023 16:08
10d3985
to
66ce350
Compare
prestist
force-pushed
the
openshift-stable
branch
5 times, most recently
from
March 13, 2023 18:42
a4a061c
to
0d90ae3
Compare
bgilbert
reviewed
Mar 13, 2023
bgilbert
reviewed
Mar 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For something like this, diffing e.g. the 4.12 and 4.13 docs/packages is a useful cross-check. It found a couple things.
The MCO doesn't support Ignition spec 3.3.0 yet, so we also need to roll back openshift 4.13.0 to fcos 1.3.0 and base 0.3
prestist
force-pushed
the
openshift-stable
branch
from
March 13, 2023 20:46
0d90ae3
to
23ce49a
Compare
bgilbert
approved these changes
Mar 14, 2023
Followup in #440. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roll back to Ignition 3.2.0 spec for #312.