Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature offer #3661

Open
Sentynel opened this issue Aug 8, 2021 · 1 comment
Open

Feature offer #3661

Sentynel opened this issue Aug 8, 2021 · 1 comment

Comments

@Sentynel
Copy link
Contributor

Sentynel commented Aug 8, 2021

Search Terms

avatar, bandcamp, imgur, import, password

Suggestion

I've just finished migrating from 4.x to 6.x on https://www.angrymetalguy.com/. As part of that process, I have made a few changes and additions. These are all based on our requirements and may not align with upstream, and most of them probably aren't quite ready for merging. However, if you are interested in any, I'm happy to work with you to polish them up for merging, so just let me know and I'll open PRs as appropriate. You can see the changes in production at the above URL, and the code in its current state at https://github.com/Sentynel/talk.

We have:

  • Disabled setting a local password for SSO accounts - the whole point of SSO is that it saves you managing yet another password.
  • Hacked together a 4.x->6.x migration script. This is by no means a complete solution to the problem, but it ports the important bits of our database successfully, stops if it hits something it doesn't expect, and should be relatively easy to extend for local requirements. It's in Python and speaks to Mongo directly, rather than trying to go through GraphQL.
  • Upgraded the avatar feature: you can now set your own avatar, report other people's avatars, see users' avatars in the moderation tool, and the display in the stream is made a little more prominent (a similar size to 4.x avatars if they were enabled).
  • Made embed paste detection work for external image URLs
  • Added Bandcamp embeds
  • Added Imgur embeds
@nick-funk
Copy link
Contributor

Hey @Sentynel, wanted to say thanks for opening this! I am going to take a deep dive into your fork when I have some time to do so! This all looks like really great work and I'm eager to dig in and see if we can bring some of it over into our code-base! Have a great weekend and thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants